chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPageDelegate.java - Issue 2571553003: Converts usage of EmbeddedContentViewActivity to CustomTabActivity.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPageDelegate.java

Issue 2571553003: Converts usage of EmbeddedContentViewActivity to CustomTabActivity. (Closed)

Patch Set: Fix an issue for url with chrome schema. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/firstrun/LightweightFirstRunActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPageDelegate.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPageDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPageDelegate.java

index c4fcf38c3410fbf88f87dbf3c04d25d96cd438e2..f42d039e9d1164d34e16c688407433b7ea437041 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPageDelegate.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPageDelegate.java

@@ -75,9 +75,8 @@ public interface FirstRunPageDelegate {

void openAccountAdder(Fragment fragment);

/**

- * Show an EmbedContentViewActivity with a given title and a URL.

- * @param title Resource id for the title of the EmbedContentViewActivity.

- * @param url Resource id for the URL of the EmbedContentViewActivity.

+ * Show an informational web page. The page doesn't show navigation control.

+ * @param url Resource id for the URL of the web page.

- void showEmbedContentViewActivity(int title, int url);

+ void showInfoPage(int url);

}