chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java - Issue 2571553003: Converts usage of EmbeddedContentViewActivity to CustomTabActivity.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java

Issue 2571553003: Converts usage of EmbeddedContentViewActivity to CustomTabActivity. (Closed)

Patch Set: Fix an issue for url with chrome schema. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java

index 5493d6bd13d73eace501f1ad3559207c6497bc76..a894354e732826c9dc32d136ef5ef693e4db5dee 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java

@@ -17,6 +17,7 @@ import org.chromium.base.VisibleForTesting;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.ChromeActivity;

import org.chromium.chrome.browser.appmenu.AppMenuPropertiesDelegate;

+import org.chromium.chrome.browser.firstrun.FirstRunStatus;

import org.chromium.chrome.browser.share.ShareHelper;

import org.chromium.chrome.browser.tab.Tab;

@@ -109,6 +110,10 @@ public class CustomTabAppMenuPropertiesDelegate extends AppMenuPropertiesDelegat

}

+ if (!FirstRunStatus.getFirstRunFlowComplete()) {

+ openInChromeItem.setVisible(false);

+ }

// Add custom menu items. Make sure they are only added once.

if (!mIsCustomEntryAdded) {

mIsCustomEntryAdded = true;