chrome/android/java/src/org/chromium/chrome/browser/datausage/DataUseTabUIManager.java - Issue 2571553003: Converts usage of EmbeddedContentViewActivity to CustomTabActivity.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/datausage/DataUseTabUIManager.java

Issue 2571553003: Converts usage of EmbeddedContentViewActivity to CustomTabActivity. (Closed)

Patch Set: Fix an issue for url with chrome schema. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/datausage/DataUseTabUIManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/datausage/DataUseTabUIManager.java b/chrome/android/java/src/org/chromium/chrome/browser/datausage/DataUseTabUIManager.java

index 52eba162a961f3a7d906aa0600d2b72bbeed9c67..388581410e08cf57820c48d813cea9d37df49802 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/datausage/DataUseTabUIManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/datausage/DataUseTabUIManager.java

@@ -18,7 +18,7 @@ import org.chromium.base.ContextUtils;

import org.chromium.base.FieldTrialList;

import org.chromium.base.metrics.RecordHistogram;

import org.chromium.chrome.R;

-import org.chromium.chrome.browser.EmbedContentViewActivity;

+import org.chromium.chrome.browser.customtabs.CustomTabActivity;

import org.chromium.chrome.browser.profiles.Profile;

import org.chromium.chrome.browser.sessions.SessionTabHelper;

import org.chromium.chrome.browser.tab.Tab;

@@ -183,8 +183,7 @@ public class DataUseTabUIManager {

learnMore.setOnClickListener(new android.view.View.OnClickListener() {

@Override

public void onClick(View v) {

- EmbedContentViewActivity.show(activity,

- getDataUseUIString(DataUseUIMessage.DATA_USE_LEARN_MORE_TITLE),

+ CustomTabActivity.showInfoPage(activity,

getDataUseUIString(DataUseUIMessage.DATA_USE_LEARN_MORE_LINK_URL));

recordDataUseUIAction(DataUsageUIAction.DIALOG_LEARN_MORE_CLICKED);

}