Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2543643002: [fullcodegen] Remove deprecated support for computed property names. (Closed)

Created:
4 years ago by Franzi
Modified:
4 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[fullcodegen] Remove deprecated support for computed property names. This code is no longer used in full-codegen since all computed property names in object literals go through Ignition first. BUG=v8:5657 Committed: https://crrev.com/1d7122beaccf1097221fdb9ce8ba774fddd0cbda Cr-Commit-Position: refs/heads/master@{#41405}

Patch Set 1 #

Patch Set 2 : Delete runtime call in VisitObjectLiteral. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -110 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 1 chunk +1 line, -11 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
Franzi
Delete _all_ the code. PTAL. Thanks, Franzi
4 years ago (2016-11-30 17:01:11 UTC) #8
Benedikt Meurer
Maybe not _all_ the code :-) But this code for sure, Yay! LGTM.
4 years ago (2016-12-01 05:12:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2543643002/20001
4 years ago (2016-12-01 05:49:58 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-01 05:51:42 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-01 05:52:14 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1d7122beaccf1097221fdb9ce8ba774fddd0cbda
Cr-Commit-Position: refs/heads/master@{#41405}

Powered by Google App Engine
This is Rietveld 408576698