Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Side by Side Diff: src/full-codegen/mips64/full-codegen-mips64.cc

Issue 2543643002: [fullcodegen] Remove deprecated support for computed property names. (Closed)
Patch Set: Delete runtime call in VisitObjectLiteral. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/mips/full-codegen-mips.cc ('k') | src/full-codegen/ppc/full-codegen-ppc.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS64 5 #if V8_TARGET_ARCH_MIPS64
6 6
7 // Note on Mips implementation: 7 // Note on Mips implementation:
8 // 8 //
9 // The result_register() for mips is the 'v0' register, which is defined 9 // The result_register() for mips is the 'v0' register, which is defined
10 // by the ABI to contain function return values. However, the first 10 // by the ABI to contain function return values. However, the first
(...skipping 1345 matching lines...) Expand 10 before | Expand all | Expand 10 after
1356 EmitPropertyKey(property, expr->GetIdForPropertyName(property_index)); 1356 EmitPropertyKey(property, expr->GetIdForPropertyName(property_index));
1357 VisitForStackValue(value); 1357 VisitForStackValue(value);
1358 if (NeedsHomeObject(value)) { 1358 if (NeedsHomeObject(value)) {
1359 EmitSetHomeObject(value, 2, property->GetSlot()); 1359 EmitSetHomeObject(value, 2, property->GetSlot());
1360 } 1360 }
1361 1361
1362 switch (property->kind()) { 1362 switch (property->kind()) {
1363 case ObjectLiteral::Property::CONSTANT: 1363 case ObjectLiteral::Property::CONSTANT:
1364 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 1364 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
1365 case ObjectLiteral::Property::COMPUTED: 1365 case ObjectLiteral::Property::COMPUTED:
1366 if (property->emit_store()) {
1367 PushOperand(Smi::FromInt(NONE));
1368 PushOperand(Smi::FromInt(property->NeedsSetFunctionName()));
1369 CallRuntimeWithOperands(Runtime::kDefineDataPropertyInLiteral);
1370 PrepareForBailoutForId(expr->GetIdForPropertySet(property_index),
1371 BailoutState::NO_REGISTERS);
1372 } else {
1373 DropOperands(3);
1374 }
1375 break;
1376
1377 case ObjectLiteral::Property::PROTOTYPE: 1366 case ObjectLiteral::Property::PROTOTYPE:
1378 UNREACHABLE(); 1367 UNREACHABLE();
1379 break; 1368 break;
1380 1369
1381 case ObjectLiteral::Property::GETTER: 1370 case ObjectLiteral::Property::GETTER:
1382 PushOperand(Smi::FromInt(NONE)); 1371 PushOperand(Smi::FromInt(NONE));
1383 CallRuntimeWithOperands(Runtime::kDefineGetterPropertyUnchecked); 1372 CallRuntimeWithOperands(Runtime::kDefineGetterPropertyUnchecked);
1384 break; 1373 break;
1385 1374
1386 case ObjectLiteral::Property::SETTER: 1375 case ObjectLiteral::Property::SETTER:
(...skipping 1782 matching lines...) Expand 10 before | Expand all | Expand 10 after
3169 reinterpret_cast<uint64_t>( 3158 reinterpret_cast<uint64_t>(
3170 isolate->builtins()->OnStackReplacement()->entry())); 3159 isolate->builtins()->OnStackReplacement()->entry()));
3171 return ON_STACK_REPLACEMENT; 3160 return ON_STACK_REPLACEMENT;
3172 } 3161 }
3173 3162
3174 3163
3175 } // namespace internal 3164 } // namespace internal
3176 } // namespace v8 3165 } // namespace v8
3177 3166
3178 #endif // V8_TARGET_ARCH_MIPS64 3167 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/full-codegen/mips/full-codegen-mips.cc ('k') | src/full-codegen/ppc/full-codegen-ppc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698