Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: src/full-codegen/ia32/full-codegen-ia32.cc

Issue 2543643002: [fullcodegen] Remove deprecated support for computed property names. (Closed)
Patch Set: Delete runtime call in VisitObjectLiteral. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_IA32 5 #if V8_TARGET_ARCH_IA32
6 6
7 #include "src/full-codegen/full-codegen.h" 7 #include "src/full-codegen/full-codegen.h"
8 #include "src/ast/compile-time-value.h" 8 #include "src/ast/compile-time-value.h"
9 #include "src/ast/scopes.h" 9 #include "src/ast/scopes.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 1267 matching lines...) Expand 10 before | Expand all | Expand 10 after
1278 EmitPropertyKey(property, expr->GetIdForPropertyName(property_index)); 1278 EmitPropertyKey(property, expr->GetIdForPropertyName(property_index));
1279 VisitForStackValue(value); 1279 VisitForStackValue(value);
1280 if (NeedsHomeObject(value)) { 1280 if (NeedsHomeObject(value)) {
1281 EmitSetHomeObject(value, 2, property->GetSlot()); 1281 EmitSetHomeObject(value, 2, property->GetSlot());
1282 } 1282 }
1283 1283
1284 switch (property->kind()) { 1284 switch (property->kind()) {
1285 case ObjectLiteral::Property::CONSTANT: 1285 case ObjectLiteral::Property::CONSTANT:
1286 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 1286 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
1287 case ObjectLiteral::Property::COMPUTED: 1287 case ObjectLiteral::Property::COMPUTED:
1288 if (property->emit_store()) {
1289 PushOperand(Smi::FromInt(NONE));
1290 PushOperand(Smi::FromInt(property->NeedsSetFunctionName()));
1291 CallRuntimeWithOperands(Runtime::kDefineDataPropertyInLiteral);
1292 PrepareForBailoutForId(expr->GetIdForPropertySet(property_index),
1293 BailoutState::NO_REGISTERS);
1294 } else {
1295 DropOperands(3);
1296 }
1297 break;
1298
1299 case ObjectLiteral::Property::PROTOTYPE: 1288 case ObjectLiteral::Property::PROTOTYPE:
1300 UNREACHABLE(); 1289 UNREACHABLE();
1301 break; 1290 break;
1302 1291
1303 case ObjectLiteral::Property::GETTER: 1292 case ObjectLiteral::Property::GETTER:
1304 PushOperand(Smi::FromInt(NONE)); 1293 PushOperand(Smi::FromInt(NONE));
1305 CallRuntimeWithOperands(Runtime::kDefineGetterPropertyUnchecked); 1294 CallRuntimeWithOperands(Runtime::kDefineGetterPropertyUnchecked);
1306 break; 1295 break;
1307 1296
1308 case ObjectLiteral::Property::SETTER: 1297 case ObjectLiteral::Property::SETTER:
(...skipping 1753 matching lines...) Expand 10 before | Expand all | Expand 10 after
3062 isolate->builtins()->OnStackReplacement()->entry(), 3051 isolate->builtins()->OnStackReplacement()->entry(),
3063 Assembler::target_address_at(call_target_address, unoptimized_code)); 3052 Assembler::target_address_at(call_target_address, unoptimized_code));
3064 return ON_STACK_REPLACEMENT; 3053 return ON_STACK_REPLACEMENT;
3065 } 3054 }
3066 3055
3067 3056
3068 } // namespace internal 3057 } // namespace internal
3069 } // namespace v8 3058 } // namespace v8
3070 3059
3071 #endif // V8_TARGET_ARCH_IA32 3060 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/full-codegen/arm64/full-codegen-arm64.cc ('k') | src/full-codegen/mips/full-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698