Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: src/full-codegen/x87/full-codegen-x87.cc

Issue 2543643002: [fullcodegen] Remove deprecated support for computed property names. (Closed)
Patch Set: Delete runtime call in VisitObjectLiteral. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/x64/full-codegen-x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X87 5 #if V8_TARGET_ARCH_X87
6 6
7 #include "src/full-codegen/full-codegen.h" 7 #include "src/full-codegen/full-codegen.h"
8 #include "src/ast/compile-time-value.h" 8 #include "src/ast/compile-time-value.h"
9 #include "src/ast/scopes.h" 9 #include "src/ast/scopes.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 1259 matching lines...) Expand 10 before | Expand all | Expand 10 after
1270 EmitPropertyKey(property, expr->GetIdForPropertyName(property_index)); 1270 EmitPropertyKey(property, expr->GetIdForPropertyName(property_index));
1271 VisitForStackValue(value); 1271 VisitForStackValue(value);
1272 if (NeedsHomeObject(value)) { 1272 if (NeedsHomeObject(value)) {
1273 EmitSetHomeObject(value, 2, property->GetSlot()); 1273 EmitSetHomeObject(value, 2, property->GetSlot());
1274 } 1274 }
1275 1275
1276 switch (property->kind()) { 1276 switch (property->kind()) {
1277 case ObjectLiteral::Property::CONSTANT: 1277 case ObjectLiteral::Property::CONSTANT:
1278 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 1278 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
1279 case ObjectLiteral::Property::COMPUTED: 1279 case ObjectLiteral::Property::COMPUTED:
1280 if (property->emit_store()) {
1281 PushOperand(Smi::FromInt(NONE));
1282 PushOperand(Smi::FromInt(property->NeedsSetFunctionName()));
1283 CallRuntimeWithOperands(Runtime::kDefineDataPropertyInLiteral);
1284 PrepareForBailoutForId(expr->GetIdForPropertySet(property_index),
1285 BailoutState::NO_REGISTERS);
1286 } else {
1287 DropOperands(3);
1288 }
1289 break;
1290
1291 case ObjectLiteral::Property::PROTOTYPE: 1280 case ObjectLiteral::Property::PROTOTYPE:
1292 UNREACHABLE(); 1281 UNREACHABLE();
1293 break; 1282 break;
1294 1283
1295 case ObjectLiteral::Property::GETTER: 1284 case ObjectLiteral::Property::GETTER:
1296 PushOperand(Smi::FromInt(NONE)); 1285 PushOperand(Smi::FromInt(NONE));
1297 CallRuntimeWithOperands(Runtime::kDefineGetterPropertyUnchecked); 1286 CallRuntimeWithOperands(Runtime::kDefineGetterPropertyUnchecked);
1298 break; 1287 break;
1299 1288
1300 case ObjectLiteral::Property::SETTER: 1289 case ObjectLiteral::Property::SETTER:
(...skipping 1753 matching lines...) Expand 10 before | Expand all | Expand 10 after
3054 isolate->builtins()->OnStackReplacement()->entry(), 3043 isolate->builtins()->OnStackReplacement()->entry(),
3055 Assembler::target_address_at(call_target_address, unoptimized_code)); 3044 Assembler::target_address_at(call_target_address, unoptimized_code));
3056 return ON_STACK_REPLACEMENT; 3045 return ON_STACK_REPLACEMENT;
3057 } 3046 }
3058 3047
3059 3048
3060 } // namespace internal 3049 } // namespace internal
3061 } // namespace v8 3050 } // namespace v8
3062 3051
3063 #endif // V8_TARGET_ARCH_X87 3052 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « src/full-codegen/x64/full-codegen-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698