Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Side by Side Diff: src/full-codegen/mips/full-codegen-mips.cc

Issue 2543643002: [fullcodegen] Remove deprecated support for computed property names. (Closed)
Patch Set: Delete runtime call in VisitObjectLiteral. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS 5 #if V8_TARGET_ARCH_MIPS
6 6
7 // Note on Mips implementation: 7 // Note on Mips implementation:
8 // 8 //
9 // The result_register() for mips is the 'v0' register, which is defined 9 // The result_register() for mips is the 'v0' register, which is defined
10 // by the ABI to contain function return values. However, the first 10 // by the ABI to contain function return values. However, the first
(...skipping 1343 matching lines...) Expand 10 before | Expand all | Expand 10 after
1354 EmitPropertyKey(property, expr->GetIdForPropertyName(property_index)); 1354 EmitPropertyKey(property, expr->GetIdForPropertyName(property_index));
1355 VisitForStackValue(value); 1355 VisitForStackValue(value);
1356 if (NeedsHomeObject(value)) { 1356 if (NeedsHomeObject(value)) {
1357 EmitSetHomeObject(value, 2, property->GetSlot()); 1357 EmitSetHomeObject(value, 2, property->GetSlot());
1358 } 1358 }
1359 1359
1360 switch (property->kind()) { 1360 switch (property->kind()) {
1361 case ObjectLiteral::Property::CONSTANT: 1361 case ObjectLiteral::Property::CONSTANT:
1362 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 1362 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
1363 case ObjectLiteral::Property::COMPUTED: 1363 case ObjectLiteral::Property::COMPUTED:
1364 if (property->emit_store()) {
1365 PushOperand(Smi::FromInt(NONE));
1366 PushOperand(Smi::FromInt(property->NeedsSetFunctionName()));
1367 CallRuntimeWithOperands(Runtime::kDefineDataPropertyInLiteral);
1368 PrepareForBailoutForId(expr->GetIdForPropertySet(property_index),
1369 BailoutState::NO_REGISTERS);
1370 } else {
1371 DropOperands(3);
1372 }
1373 break;
1374
1375 case ObjectLiteral::Property::PROTOTYPE: 1364 case ObjectLiteral::Property::PROTOTYPE:
1376 UNREACHABLE(); 1365 UNREACHABLE();
1377 break; 1366 break;
1378 1367
1379 case ObjectLiteral::Property::GETTER: 1368 case ObjectLiteral::Property::GETTER:
1380 PushOperand(Smi::FromInt(NONE)); 1369 PushOperand(Smi::FromInt(NONE));
1381 CallRuntimeWithOperands(Runtime::kDefineGetterPropertyUnchecked); 1370 CallRuntimeWithOperands(Runtime::kDefineGetterPropertyUnchecked);
1382 break; 1371 break;
1383 1372
1384 case ObjectLiteral::Property::SETTER: 1373 case ObjectLiteral::Property::SETTER:
(...skipping 1775 matching lines...) Expand 10 before | Expand all | Expand 10 after
3160 reinterpret_cast<uint32_t>( 3149 reinterpret_cast<uint32_t>(
3161 isolate->builtins()->OnStackReplacement()->entry())); 3150 isolate->builtins()->OnStackReplacement()->entry()));
3162 return ON_STACK_REPLACEMENT; 3151 return ON_STACK_REPLACEMENT;
3163 } 3152 }
3164 3153
3165 3154
3166 } // namespace internal 3155 } // namespace internal
3167 } // namespace v8 3156 } // namespace v8
3168 3157
3169 #endif // V8_TARGET_ARCH_MIPS 3158 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/full-codegen/ia32/full-codegen-ia32.cc ('k') | src/full-codegen/mips64/full-codegen-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698