Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: src/full-codegen/arm64/full-codegen-arm64.cc

Issue 2543643002: [fullcodegen] Remove deprecated support for computed property names. (Closed)
Patch Set: Delete runtime call in VisitObjectLiteral. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/arm/full-codegen-arm.cc ('k') | src/full-codegen/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM64 5 #if V8_TARGET_ARCH_ARM64
6 6
7 #include "src/full-codegen/full-codegen.h" 7 #include "src/full-codegen/full-codegen.h"
8 #include "src/ast/compile-time-value.h" 8 #include "src/ast/compile-time-value.h"
9 #include "src/ast/scopes.h" 9 #include "src/ast/scopes.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 1329 matching lines...) Expand 10 before | Expand all | Expand 10 after
1340 EmitPropertyKey(property, expr->GetIdForPropertyName(property_index)); 1340 EmitPropertyKey(property, expr->GetIdForPropertyName(property_index));
1341 VisitForStackValue(value); 1341 VisitForStackValue(value);
1342 if (NeedsHomeObject(value)) { 1342 if (NeedsHomeObject(value)) {
1343 EmitSetHomeObject(value, 2, property->GetSlot()); 1343 EmitSetHomeObject(value, 2, property->GetSlot());
1344 } 1344 }
1345 1345
1346 switch (property->kind()) { 1346 switch (property->kind()) {
1347 case ObjectLiteral::Property::CONSTANT: 1347 case ObjectLiteral::Property::CONSTANT:
1348 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 1348 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
1349 case ObjectLiteral::Property::COMPUTED: 1349 case ObjectLiteral::Property::COMPUTED:
1350 if (property->emit_store()) {
1351 PushOperand(Smi::FromInt(NONE));
1352 PushOperand(Smi::FromInt(property->NeedsSetFunctionName()));
1353 CallRuntimeWithOperands(Runtime::kDefineDataPropertyInLiteral);
1354 PrepareForBailoutForId(expr->GetIdForPropertySet(property_index),
1355 BailoutState::NO_REGISTERS);
1356 } else {
1357 DropOperands(3);
1358 }
1359 break;
1360
1361 case ObjectLiteral::Property::PROTOTYPE: 1350 case ObjectLiteral::Property::PROTOTYPE:
1362 UNREACHABLE(); 1351 UNREACHABLE();
1363 break; 1352 break;
1364 1353
1365 case ObjectLiteral::Property::GETTER: 1354 case ObjectLiteral::Property::GETTER:
1366 PushOperand(Smi::FromInt(NONE)); 1355 PushOperand(Smi::FromInt(NONE));
1367 CallRuntimeWithOperands(Runtime::kDefineGetterPropertyUnchecked); 1356 CallRuntimeWithOperands(Runtime::kDefineGetterPropertyUnchecked);
1368 break; 1357 break;
1369 1358
1370 case ObjectLiteral::Property::SETTER: 1359 case ObjectLiteral::Property::SETTER:
(...skipping 1838 matching lines...) Expand 10 before | Expand all | Expand 10 after
3209 } 3198 }
3210 3199
3211 return INTERRUPT; 3200 return INTERRUPT;
3212 } 3201 }
3213 3202
3214 3203
3215 } // namespace internal 3204 } // namespace internal
3216 } // namespace v8 3205 } // namespace v8
3217 3206
3218 #endif // V8_TARGET_ARCH_ARM64 3207 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/full-codegen/arm/full-codegen-arm.cc ('k') | src/full-codegen/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698