Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Side by Side Diff: src/full-codegen/arm/full-codegen-arm.cc

Issue 2543643002: [fullcodegen] Remove deprecated support for computed property names. (Closed)
Patch Set: Delete runtime call in VisitObjectLiteral. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/full-codegen/full-codegen.h" 7 #include "src/full-codegen/full-codegen.h"
8 #include "src/ast/compile-time-value.h" 8 #include "src/ast/compile-time-value.h"
9 #include "src/ast/scopes.h" 9 #include "src/ast/scopes.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 1344 matching lines...) Expand 10 before | Expand all | Expand 10 after
1355 EmitPropertyKey(property, expr->GetIdForPropertyName(property_index)); 1355 EmitPropertyKey(property, expr->GetIdForPropertyName(property_index));
1356 VisitForStackValue(value); 1356 VisitForStackValue(value);
1357 if (NeedsHomeObject(value)) { 1357 if (NeedsHomeObject(value)) {
1358 EmitSetHomeObject(value, 2, property->GetSlot()); 1358 EmitSetHomeObject(value, 2, property->GetSlot());
1359 } 1359 }
1360 1360
1361 switch (property->kind()) { 1361 switch (property->kind()) {
1362 case ObjectLiteral::Property::CONSTANT: 1362 case ObjectLiteral::Property::CONSTANT:
1363 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 1363 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
1364 case ObjectLiteral::Property::COMPUTED: 1364 case ObjectLiteral::Property::COMPUTED:
1365 if (property->emit_store()) {
1366 PushOperand(Smi::FromInt(NONE));
1367 PushOperand(Smi::FromInt(property->NeedsSetFunctionName()));
1368 CallRuntimeWithOperands(Runtime::kDefineDataPropertyInLiteral);
1369 PrepareForBailoutForId(expr->GetIdForPropertySet(property_index),
1370 BailoutState::NO_REGISTERS);
1371 } else {
1372 DropOperands(3);
1373 }
1374 break;
1375
1376 case ObjectLiteral::Property::PROTOTYPE: 1365 case ObjectLiteral::Property::PROTOTYPE:
1377 UNREACHABLE(); 1366 UNREACHABLE();
1378 break; 1367 break;
1379 1368
1380 case ObjectLiteral::Property::GETTER: 1369 case ObjectLiteral::Property::GETTER:
1381 PushOperand(Smi::FromInt(NONE)); 1370 PushOperand(Smi::FromInt(NONE));
1382 CallRuntimeWithOperands(Runtime::kDefineGetterPropertyUnchecked); 1371 CallRuntimeWithOperands(Runtime::kDefineGetterPropertyUnchecked);
1383 break; 1372 break;
1384 1373
1385 case ObjectLiteral::Property::SETTER: 1374 case ObjectLiteral::Property::SETTER:
(...skipping 1825 matching lines...) Expand 10 before | Expand all | Expand 10 after
3211 DCHECK(interrupt_address == 3200 DCHECK(interrupt_address ==
3212 isolate->builtins()->OnStackReplacement()->entry()); 3201 isolate->builtins()->OnStackReplacement()->entry());
3213 return ON_STACK_REPLACEMENT; 3202 return ON_STACK_REPLACEMENT;
3214 } 3203 }
3215 3204
3216 3205
3217 } // namespace internal 3206 } // namespace internal
3218 } // namespace v8 3207 } // namespace v8
3219 3208
3220 #endif // V8_TARGET_ARCH_ARM 3209 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698