Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Side by Side Diff: src/full-codegen/ppc/full-codegen-ppc.cc

Issue 2543643002: [fullcodegen] Remove deprecated support for computed property names. (Closed)
Patch Set: Delete runtime call in VisitObjectLiteral. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_PPC 5 #if V8_TARGET_ARCH_PPC
6 6
7 #include "src/full-codegen/full-codegen.h" 7 #include "src/full-codegen/full-codegen.h"
8 #include "src/ast/compile-time-value.h" 8 #include "src/ast/compile-time-value.h"
9 #include "src/ast/scopes.h" 9 #include "src/ast/scopes.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 1313 matching lines...) Expand 10 before | Expand all | Expand 10 after
1324 EmitPropertyKey(property, expr->GetIdForPropertyName(property_index)); 1324 EmitPropertyKey(property, expr->GetIdForPropertyName(property_index));
1325 VisitForStackValue(value); 1325 VisitForStackValue(value);
1326 if (NeedsHomeObject(value)) { 1326 if (NeedsHomeObject(value)) {
1327 EmitSetHomeObject(value, 2, property->GetSlot()); 1327 EmitSetHomeObject(value, 2, property->GetSlot());
1328 } 1328 }
1329 1329
1330 switch (property->kind()) { 1330 switch (property->kind()) {
1331 case ObjectLiteral::Property::CONSTANT: 1331 case ObjectLiteral::Property::CONSTANT:
1332 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 1332 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
1333 case ObjectLiteral::Property::COMPUTED: 1333 case ObjectLiteral::Property::COMPUTED:
1334 if (property->emit_store()) {
1335 PushOperand(Smi::FromInt(NONE));
1336 PushOperand(Smi::FromInt(property->NeedsSetFunctionName()));
1337 CallRuntimeWithOperands(Runtime::kDefineDataPropertyInLiteral);
1338 PrepareForBailoutForId(expr->GetIdForPropertySet(property_index),
1339 BailoutState::NO_REGISTERS);
1340 } else {
1341 DropOperands(3);
1342 }
1343 break;
1344
1345 case ObjectLiteral::Property::PROTOTYPE: 1334 case ObjectLiteral::Property::PROTOTYPE:
1346 UNREACHABLE(); 1335 UNREACHABLE();
1347 break; 1336 break;
1348 1337
1349 case ObjectLiteral::Property::GETTER: 1338 case ObjectLiteral::Property::GETTER:
1350 PushOperand(Smi::FromInt(NONE)); 1339 PushOperand(Smi::FromInt(NONE));
1351 CallRuntimeWithOperands(Runtime::kDefineGetterPropertyUnchecked); 1340 CallRuntimeWithOperands(Runtime::kDefineGetterPropertyUnchecked);
1352 break; 1341 break;
1353 1342
1354 case ObjectLiteral::Property::SETTER: 1343 case ObjectLiteral::Property::SETTER:
(...skipping 1786 matching lines...) Expand 10 before | Expand all | Expand 10 after
3141 3130
3142 DCHECK(Assembler::IsCrSet(Assembler::instr_at(cmp_address))); 3131 DCHECK(Assembler::IsCrSet(Assembler::instr_at(cmp_address)));
3143 3132
3144 DCHECK(interrupt_address == 3133 DCHECK(interrupt_address ==
3145 isolate->builtins()->OnStackReplacement()->entry()); 3134 isolate->builtins()->OnStackReplacement()->entry());
3146 return ON_STACK_REPLACEMENT; 3135 return ON_STACK_REPLACEMENT;
3147 } 3136 }
3148 } // namespace internal 3137 } // namespace internal
3149 } // namespace v8 3138 } // namespace v8
3150 #endif // V8_TARGET_ARCH_PPC 3139 #endif // V8_TARGET_ARCH_PPC
OLDNEW
« no previous file with comments | « src/full-codegen/mips64/full-codegen-mips64.cc ('k') | src/full-codegen/s390/full-codegen-s390.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698