Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 2541183002: cc: Rename ImageDecodeController to ImageDecodeCache. (Closed)

Created:
4 years ago by vmpstr
Modified:
4 years ago
Reviewers:
enne (OOO), ericrk
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Rename ImageDecodeController to ImageDecodeCache. This patch renames ImageDecodeController to ImageDecodeCache, along with software and gpu implementations. R=enne@chromium.org, ericrk@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Committed: https://crrev.com/70289fb699a311cf74de0853951145a90c35a5f5 Cr-Commit-Position: refs/heads/master@{#435530}

Patch Set 1 #

Patch Set 2 : rename: update #

Patch Set 3 : rename: update #

Patch Set 4 : rename: update #

Patch Set 5 : rename: update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+969 lines, -6944 lines) Patch
M cc/BUILD.gn View 1 2 3 3 chunks +7 lines, -7 lines 0 comments Download
M cc/layers/picture_layer_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M cc/output/software_renderer.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/playback/image_hijack_canvas.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/playback/image_hijack_canvas.cc View 7 chunks +13 lines, -15 lines 0 comments Download
M cc/playback/raster_source.h View 1 2 3 3 chunks +8 lines, -11 lines 0 comments Download
M cc/playback/raster_source.cc View 1 2 3 3 chunks +3 lines, -5 lines 0 comments Download
M cc/playback/raster_source_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/raster/gpu_raster_buffer_provider.cc View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M cc/test/fake_tile_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/test/fake_tile_manager.cc View 2 chunks +7 lines, -8 lines 0 comments Download
A + cc/tiles/gpu_image_decode_cache.h View 7 chunks +15 lines, -15 lines 0 comments Download
A + cc/tiles/gpu_image_decode_cache.cc View 46 chunks +101 lines, -109 lines 0 comments Download
A + cc/tiles/gpu_image_decode_cache_unittest.cc View 79 chunks +324 lines, -327 lines 0 comments Download
D cc/tiles/gpu_image_decode_controller.h View 1 chunk +0 lines, -334 lines 0 comments Download
D cc/tiles/gpu_image_decode_controller.cc View 1 chunk +0 lines, -1245 lines 0 comments Download
D cc/tiles/gpu_image_decode_controller_unittest.cc View 1 chunk +0 lines, -1368 lines 0 comments Download
A + cc/tiles/image_decode_cache.h View 6 chunks +9 lines, -9 lines 0 comments Download
D cc/tiles/image_decode_controller.h View 1 chunk +0 lines, -91 lines 0 comments Download
M cc/tiles/image_manager.h View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M cc/tiles/image_manager.cc View 1 2 chunks +15 lines, -15 lines 0 comments Download
M cc/tiles/image_manager_unittest.cc View 1 2 chunks +9 lines, -9 lines 0 comments Download
A + cc/tiles/software_image_decode_cache.h View 8 chunks +30 lines, -31 lines 0 comments Download
A + cc/tiles/software_image_decode_cache.cc View 38 chunks +96 lines, -111 lines 0 comments Download
A + cc/tiles/software_image_decode_cache_unittest.cc View 111 chunks +274 lines, -282 lines 0 comments Download
D cc/tiles/software_image_decode_controller.h View 1 chunk +0 lines, -298 lines 0 comments Download
D cc/tiles/software_image_decode_controller.cc View 1 chunk +0 lines, -1136 lines 0 comments Download
D cc/tiles/software_image_decode_controller_unittest.cc View 1 chunk +0 lines, -1458 lines 0 comments Download
M cc/tiles/tile_manager.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M cc/tiles/tile_manager.cc View 1 2 3 5 chunks +7 lines, -7 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 2 3 3 chunks +3 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 3 7 chunks +16 lines, -16 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
vmpstr
Behold, a rename patch!
4 years ago (2016-11-30 22:47:08 UTC) #2
enne (OOO)
lgtm, thanks!
4 years ago (2016-11-30 22:58:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541183002/40001
4 years ago (2016-12-01 00:19:31 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/315289) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years ago (2016-12-01 00:22:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541183002/60001
4 years ago (2016-12-01 01:09:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541183002/80001
4 years ago (2016-12-01 01:21:19 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years ago (2016-12-01 02:33:39 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-01 02:36:19 UTC) #19
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/70289fb699a311cf74de0853951145a90c35a5f5
Cr-Commit-Position: refs/heads/master@{#435530}

Powered by Google App Engine
This is Rietveld 408576698