Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Side by Side Diff: cc/tiles/image_manager_unittest.cc

Issue 2541183002: cc: Rename ImageDecodeController to ImageDecodeCache. (Closed)
Patch Set: rename: update Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/tiles/image_manager.cc ('k') | cc/tiles/software_image_decode_cache.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/tiles/image_decode_controller.h" 5 #include "cc/tiles/image_decode_cache.h"
6 #include "cc/tiles/image_manager.h" 6 #include "cc/tiles/image_manager.h"
7 #include "testing/gtest/include/gtest/gtest.h" 7 #include "testing/gtest/include/gtest/gtest.h"
8 8
9 namespace cc { 9 namespace cc {
10 10
11 class TestableController : public ImageDecodeController { 11 class TestableCache : public ImageDecodeCache {
12 public: 12 public:
13 bool GetTaskForImageAndRef(const DrawImage& image, 13 bool GetTaskForImageAndRef(const DrawImage& image,
14 const TracingInfo& tracing_info, 14 const TracingInfo& tracing_info,
15 scoped_refptr<TileTask>* task) override { 15 scoped_refptr<TileTask>* task) override {
16 *task = nullptr; 16 *task = nullptr;
17 ++number_of_refs_; 17 ++number_of_refs_;
18 return true; 18 return true;
19 } 19 }
20 20
21 void UnrefImage(const DrawImage& image) override { 21 void UnrefImage(const DrawImage& image) override {
22 ASSERT_GT(number_of_refs_, 0); 22 ASSERT_GT(number_of_refs_, 0);
23 --number_of_refs_; 23 --number_of_refs_;
24 } 24 }
25 DecodedDrawImage GetDecodedImageForDraw(const DrawImage& image) override { 25 DecodedDrawImage GetDecodedImageForDraw(const DrawImage& image) override {
26 return DecodedDrawImage(nullptr, kNone_SkFilterQuality); 26 return DecodedDrawImage(nullptr, kNone_SkFilterQuality);
27 } 27 }
28 void DrawWithImageFinished(const DrawImage& image, 28 void DrawWithImageFinished(const DrawImage& image,
29 const DecodedDrawImage& decoded_image) override {} 29 const DecodedDrawImage& decoded_image) override {}
30 void ReduceCacheUsage() override {} 30 void ReduceCacheUsage() override {}
31 void SetShouldAggressivelyFreeResources( 31 void SetShouldAggressivelyFreeResources(
32 bool aggressively_free_resources) override {} 32 bool aggressively_free_resources) override {}
33 33
34 int number_of_refs() const { return number_of_refs_; } 34 int number_of_refs() const { return number_of_refs_; }
35 35
36 private: 36 private:
37 int number_of_refs_ = 0; 37 int number_of_refs_ = 0;
38 }; 38 };
39 39
40 TEST(ImageManagerTest, NullControllerUnrefsImages) { 40 TEST(ImageManagerTest, NullCacheUnrefsImages) {
41 TestableController controller; 41 TestableCache cache;
42 ImageManager manager; 42 ImageManager manager;
43 manager.SetImageDecodeController(&controller); 43 manager.SetImageDecodeCache(&cache);
44 44
45 std::vector<DrawImage> images(10); 45 std::vector<DrawImage> images(10);
46 ImageDecodeController::TracingInfo tracing_info; 46 ImageDecodeCache::TracingInfo tracing_info;
47 47
48 ASSERT_EQ(10u, images.size()); 48 ASSERT_EQ(10u, images.size());
49 auto tasks = manager.SetPredecodeImages(std::move(images), tracing_info); 49 auto tasks = manager.SetPredecodeImages(std::move(images), tracing_info);
50 EXPECT_EQ(0u, tasks.size()); 50 EXPECT_EQ(0u, tasks.size());
51 EXPECT_EQ(10, controller.number_of_refs()); 51 EXPECT_EQ(10, cache.number_of_refs());
52 52
53 manager.SetImageDecodeController(nullptr); 53 manager.SetImageDecodeCache(nullptr);
54 EXPECT_EQ(0, controller.number_of_refs()); 54 EXPECT_EQ(0, cache.number_of_refs());
55 } 55 }
56 56
57 } // namespace cc 57 } // namespace cc
OLDNEW
« no previous file with comments | « cc/tiles/image_manager.cc ('k') | cc/tiles/software_image_decode_cache.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698