Emit console warning when element.animate() keyframe value fails to parse

Emit console warning when element.animate() keyframe value fails to parse

This change adds a return value to the CSS parser to state whether a
CSS value was parsed successfully for a given property.

This information is used to allow calls to element.animate() to warn the
developer when provided keyframe values are invalid.

BUG=618157
Committed: https://crrev.com/1ddf77acbf3b11ee0a3922ca5c1df57d769bac83
Cr-Commit-Position: refs/heads/master@{#434490}

[alancutter (OOO until 2018), 2016-11-24 07:35:40]

alancutter@chromium.org changed reviewers:
+ timloh@chromium.org

[Timothy Loh, 2016-11-24 23:00:23]

When does using didChange instead of didParse do the wrong thing for these
warnings?

https://codereview.chromium.org/2524303002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/animations/element-animate-keyframe-value-warning.html
(right):

https://codereview.chromium.org/2524303002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/animations/element-animate-keyframe-value-warning.html:2:
This test passes if there are three warninga about invalid keyframe values.
warninga -> warnings

[alancutter (OOO until 2018), 2016-11-25 00:59:50]

On 2016/11/24 at 23:00:23, timloh wrote:
> When does using didChange instead of didParse do the wrong thing for these
warnings?
> 

Added test case that warns incorrectly when using didChange.

>
https://codereview.chromium.org/2524303002/diff/1/third_party/WebKit/LayoutTe...
> File
third_party/WebKit/LayoutTests/animations/element-animate-keyframe-value-warning.html
(right):
> 
>
https://codereview.chromium.org/2524303002/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/animations/element-animate-keyframe-value-warning.html:2:
This test passes if there are three warninga about invalid keyframe values.
> warninga -> warnings

Done.

[alancutter (OOO until 2018), 2016-11-25 01:00:21]

On 2016/11/25 at 00:59:50, alancutter wrote:
> On 2016/11/24 at 23:00:23, timloh wrote:
> > When does using didChange instead of didParse do the wrong thing for these
warnings?
> > 
> 
> Added test case that warns incorrectly when using didChange.
> 

target.animate([{background: 'green', backgroundColor: 'green'}]);

[alancutter (OOO until 2018), 2016-11-25 01:00:58]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 01:01:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Timothy Loh, 2016-11-25 01:40:59]

lgtm

https://codereview.chromium.org/2524303002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/DOMWindowCSS.cpp (right):

https://codereview.chromium.org/2524303002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/DOMWindowCSS.cpp:51: .didChange;
We might as well change these to didParse.

https://codereview.chromium.org/2524303002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/parser/CSSParser.cpp (right):

https://codereview.chromium.org/2524303002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSParser.cpp:85: bool didParse =
true;
false probably

https://codereview.chromium.org/2524303002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSParser.cpp:118: bool didParse =
true;
false

[commit-bot: I haz the power, 2016-11-25 02:20:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 02:20:42]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[alancutter (OOO until 2018), 2016-11-25 11:59:26]

https://codereview.chromium.org/2524303002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/DOMWindowCSS.cpp (right):

https://codereview.chromium.org/2524303002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/DOMWindowCSS.cpp:51: .didChange;
On 2016/11/25 at 01:40:59, Timothy Loh wrote:
> We might as well change these to didParse.

Done.

https://codereview.chromium.org/2524303002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/parser/CSSParser.cpp (right):

https://codereview.chromium.org/2524303002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSParser.cpp:85: bool didParse =
true;
On 2016/11/25 at 01:40:59, Timothy Loh wrote:
> false probably

Done.

https://codereview.chromium.org/2524303002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSParser.cpp:85: bool didParse =
true;
On 2016/11/25 at 01:40:59, Timothy Loh wrote:
> false probably

Done.

[alancutter (OOO until 2018), 2016-11-25 11:59:30]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2016-11-25 11:59:30]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/2524303002/#ps60001
(title: "Review changes")

[commit-bot: I haz the power, 2016-11-25 11:59:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 13:21:56]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1480075170038620,
"parent_rev": "67fb51fe84944f11e836720eea16ee5351afe90a", "commit_rev":
"bb6534a20c3d3de27860bb516034057c31d80ea1"}

[commit-bot: I haz the power, 2016-11-25 13:22:25]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-25 13:25:50]

Description was changed from

==========
Emit console warning when element.animate() keyframe value fails to parse

This change adds a return value to the CSS parser to state whether a
CSS value was parsed successfully for a given property.

This information is used to allow calls to element.animate() to warn the
developer when provided keyframe values are invalid.

BUG=618157
==========

to

==========
Emit console warning when element.animate() keyframe value fails to parse

This change adds a return value to the CSS parser to state whether a
CSS value was parsed successfully for a given property.

This information is used to allow calls to element.animate() to warn the
developer when provided keyframe values are invalid.

BUG=618157

Committed: https://crrev.com/1ddf77acbf3b11ee0a3922ca5c1df57d769bac83
Cr-Commit-Position: refs/heads/master@{#434490}
==========

[commit-bot: I haz the power, 2016-11-25 13:25:52]

Patchset 4 (id:??) landed as
https://crrev.com/1ddf77acbf3b11ee0a3922ca5c1df57d769bac83
Cr-Commit-Position: refs/heads/master@{#434490}