Emit console warning when element.animate() keyframe value fails to parse

third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/css/parser/CSSParserImpl.h"
 
 #include "core/css/CSSCustomIdentValue.h"
 #include "core/css/CSSCustomPropertyDeclaration.h"
 #include "core/css/CSSKeyframesRule.h"
 #include "core/css/CSSStyleSheet.h"
-#include "core/css/StylePropertySet.h"
 #include "core/css/StyleRuleImport.h"
 #include "core/css/StyleRuleKeyframe.h"
 #include "core/css/StyleRuleNamespace.h"
 #include "core/css/StyleSheetContents.h"
 #include "core/css/parser/CSSAtRuleID.h"
 #include "core/css/parser/CSSLazyParsingState.h"
 #include "core/css/parser/CSSLazyPropertyParserImpl.h"
 #include "core/css/parser/CSSParserObserver.h"
 #include "core/css/parser/CSSParserObserverWrapper.h"
 #include "core/css/parser/CSSParserSelector.h"
@@ skipping 13 matching lines @@
 #include <memory>
 
 namespace blink {
 
 CSSParserImpl::CSSParserImpl(const CSSParserContext& context,
                              StyleSheetContents* styleSheet)
     : m_context(context),
       m_styleSheet(styleSheet),
       m_observerWrapper(nullptr) {}
 
-bool CSSParserImpl::parseValue(MutableStylePropertySet* declaration,
-                               CSSPropertyID unresolvedProperty,
-                               const String& string,
-                               bool important,
-                               const CSSParserContext& context) {
+MutableStylePropertySet::SetResult CSSParserImpl::parseValue(
+    MutableStylePropertySet* declaration,
+    CSSPropertyID unresolvedProperty,
+    const String& string,
+    bool important,
+    const CSSParserContext& context) {
   CSSParserImpl parser(context);
   StyleRule::RuleType ruleType = StyleRule::Style;
   if (declaration->cssParserMode() == CSSViewportRuleMode)
     ruleType = StyleRule::Viewport;
   else if (declaration->cssParserMode() == CSSFontFaceRuleMode)
     ruleType = StyleRule::FontFace;
   CSSTokenizer tokenizer(string);
   parser.consumeDeclarationValue(tokenizer.tokenRange(), unresolvedProperty,
                                  important, ruleType);
-  if (parser.m_parsedProperties.isEmpty())
-    return false;
-  return declaration->addParsedProperties(parser.m_parsedProperties);
+  bool didParse = false;
+  bool didChange = false;
+  if (!parser.m_parsedProperties.isEmpty()) {
+    didParse = true;
+    didChange = declaration->addParsedProperties(parser.m_parsedProperties);
+  }
+  return MutableStylePropertySet::SetResult{didParse, didChange};
 }
 
-bool CSSParserImpl::parseVariableValue(MutableStylePropertySet* declaration,
-                                       const AtomicString& propertyName,
-                                       const String& value,
-                                       bool important,
-                                       const CSSParserContext& context,
-                                       bool isAnimationTainted) {
+MutableStylePropertySet::SetResult CSSParserImpl::parseVariableValue(
+    MutableStylePropertySet* declaration,
+    const AtomicString& propertyName,
+    const String& value,
+    bool important,
+    const CSSParserContext& context,
+    bool isAnimationTainted) {
   CSSParserImpl parser(context);
   CSSTokenizer tokenizer(value);
   parser.consumeVariableValue(tokenizer.tokenRange(), propertyName, important,
                               isAnimationTainted);
-  if (parser.m_parsedProperties.isEmpty())
-    return false;
-  return declaration->addParsedProperties(parser.m_parsedProperties);
+  bool didParse = false;
+  bool didChange = false;
+  if (!parser.m_parsedProperties.isEmpty()) {
+    didParse = true;
+    didChange = declaration->addParsedProperties(parser.m_parsedProperties);
+  }
+  return MutableStylePropertySet::SetResult{didParse, didChange};
 }
 
 static inline void filterProperties(
     bool important,
     const HeapVector<CSSProperty, 256>& input,
     HeapVector<CSSProperty, 256>& output,
     size_t& unusedEntries,
     std::bitset<numCSSProperties>& seenProperties,
     HashSet<AtomicString>& seenCustomProperties) {
   // Add properties in reverse order so that highest priority definitions are
@@ skipping 869 matching lines @@
     else
       return nullptr;  // Parser error, invalid value in keyframe selector
     if (range.atEnd())
       return result;
     if (range.consume().type() != CommaToken)
       return nullptr;  // Parser error
   }
 }
 
 }  // namespace blink