Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2524303002: Emit console warning when element.animate() keyframe value fails to parse (Closed)
Patch Set: Review changes Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Element.cpp
diff --git a/third_party/WebKit/Source/core/dom/Element.cpp b/third_party/WebKit/Source/core/dom/Element.cpp
index bfaa2f8bb88134a6766ff2b6fdf50b6ff9cea07d..fd79b779eabf4799b7ba977e3148225b61db4544 100644
--- a/third_party/WebKit/Source/core/dom/Element.cpp
+++ b/third_party/WebKit/Source/core/dom/Element.cpp
@@ -3908,21 +3908,23 @@ bool Element::setInlineStyleProperty(CSSPropertyID propertyID,
const String& value,
bool important) {
DCHECK(isStyledElement());
- bool changes = ensureMutableInlineStyle().setProperty(
- propertyID, value, important, document().elementSheet().contents());
- if (changes)
+ bool didChange = ensureMutableInlineStyle()
+ .setProperty(propertyID, value, important,
+ document().elementSheet().contents())
+ .didChange;
+ if (didChange)
inlineStyleChanged();
- return changes;
+ return didChange;
}
bool Element::removeInlineStyleProperty(CSSPropertyID propertyID) {
DCHECK(isStyledElement());
if (!inlineStyle())
return false;
- bool changes = ensureMutableInlineStyle().removeProperty(propertyID);
- if (changes)
+ bool didChange = ensureMutableInlineStyle().removeProperty(propertyID);
+ if (didChange)
inlineStyleChanged();
- return changes;
+ return didChange;
}
void Element::removeAllInlineStyleProperties() {
« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp ('k') | third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698