Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: third_party/WebKit/Source/core/css/StylePropertySet.h

Issue 2524303002: Emit console warning when element.animate() keyframe value fails to parse (Closed)
Patch Set: Review changes Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/StylePropertySet.h
diff --git a/third_party/WebKit/Source/core/css/StylePropertySet.h b/third_party/WebKit/Source/core/css/StylePropertySet.h
index b37343ed7b4a78a378243ed92a62bf10b8477626..edf15327815ac3a3577e500375fa7d3a32e60927 100644
--- a/third_party/WebKit/Source/core/css/StylePropertySet.h
+++ b/third_party/WebKit/Source/core/css/StylePropertySet.h
@@ -224,16 +224,20 @@ class CORE_EXPORT MutableStylePropertySet : public StylePropertySet {
bool addParsedProperties(const HeapVector<CSSProperty, 256>&);
bool addRespectingCascade(const CSSProperty&);
+ struct SetResult {
+ bool didParse;
+ bool didChange;
+ };
// These expand shorthand properties into multiple properties.
- bool setProperty(CSSPropertyID unresolvedProperty,
- const String& value,
- bool important = false,
- StyleSheetContents* contextStyleSheet = 0);
- bool setProperty(const AtomicString& customPropertyName,
- const String& value,
- bool important,
- StyleSheetContents* contextStyleSheet,
- bool isAnimationTainted);
+ SetResult setProperty(CSSPropertyID unresolvedProperty,
+ const String& value,
+ bool important = false,
+ StyleSheetContents* contextStyleSheet = 0);
+ SetResult setProperty(const AtomicString& customPropertyName,
+ const String& value,
+ bool important,
+ StyleSheetContents* contextStyleSheet,
+ bool isAnimationTainted);
void setProperty(CSSPropertyID, const CSSValue&, bool important = false);
// These do not. FIXME: This is too messy, we can do better.

Powered by Google App Engine
This is Rietveld 408576698