Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1919)

Unified Diff: third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp

Issue 2524303002: Emit console warning when element.animate() keyframe value fails to parse (Closed)
Patch Set: Review changes Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp
diff --git a/third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp b/third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp
index ecfbcd2b51545955edb2436a358da8265f027303..59fd3aef8025c866c8afee136f5cf8de42953b6c 100644
--- a/third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp
+++ b/third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp
@@ -302,20 +302,24 @@ void AbstractPropertySetCSSStyleDeclaration::setPropertyInternal(
StyleAttributeMutationScope mutationScope(this);
willMutate();
- bool changed = false;
+ bool didChange = false;
if (unresolvedProperty == CSSPropertyVariable) {
bool isAnimationTainted = isKeyframeStyle();
- changed = propertySet().setProperty(AtomicString(customPropertyName), value,
- important, contextStyleSheet(),
- isAnimationTainted);
+ didChange =
+ propertySet()
+ .setProperty(AtomicString(customPropertyName), value, important,
+ contextStyleSheet(), isAnimationTainted)
+ .didChange;
} else {
- changed = propertySet().setProperty(unresolvedProperty, value, important,
- contextStyleSheet());
+ didChange = propertySet()
+ .setProperty(unresolvedProperty, value, important,
+ contextStyleSheet())
+ .didChange;
}
- didMutate(changed ? PropertyChanged : NoChanges);
+ didMutate(didChange ? PropertyChanged : NoChanges);
- if (!changed)
+ if (!didChange)
return;
Element* parent = parentElement();
« no previous file with comments | « third_party/WebKit/Source/core/css/DOMWindowCSS.cpp ('k') | third_party/WebKit/Source/core/css/StylePropertySet.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698