Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Unified Diff: third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp

Issue 2524303002: Emit console warning when element.animate() keyframe value fails to parse (Closed)
Patch Set: Review changes Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/Element.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp b/third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp
index 0da36fda5a0a4bca0fbef254e692da32f32eab33..67e710b6f227f0a0e333521b3583384e95d910cb 100644
--- a/third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp
@@ -355,9 +355,10 @@ void SVGAnimateElement::applyResultsToTarget() {
// property on the target.
MutableStylePropertySet* propertySet =
targetElement()->ensureAnimatedSMILStyleProperties();
- if (propertySet->setProperty(m_animator.cssProperty(),
- m_animatedProperty->valueAsString(), false,
- 0)) {
+ if (propertySet
+ ->setProperty(m_animator.cssProperty(),
+ m_animatedProperty->valueAsString(), false, 0)
+ .didChange) {
targetElement()->setNeedsStyleRecalc(
LocalStyleChange,
StyleChangeReasonForTracing::create(StyleChangeReason::Animation));
« no previous file with comments | « third_party/WebKit/Source/core/dom/Element.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698