Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Unified Diff: third_party/WebKit/Source/core/css/DOMWindowCSS.cpp

Issue 2524303002: Emit console warning when element.animate() keyframe value fails to parse (Closed)
Patch Set: Review changes Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/DOMWindowCSS.cpp
diff --git a/third_party/WebKit/Source/core/css/DOMWindowCSS.cpp b/third_party/WebKit/Source/core/css/DOMWindowCSS.cpp
index 9c0e4681442cecd1482894cc47d1255fce588ec2..c1196921398871840477101b6e00af728e1a4ede 100644
--- a/third_party/WebKit/Source/core/css/DOMWindowCSS.cpp
+++ b/third_party/WebKit/Source/core/css/DOMWindowCSS.cpp
@@ -47,7 +47,8 @@ bool DOMWindowCSS::supports(const String& property, const String& value) {
MutableStylePropertySet::create(HTMLStandardMode);
bool isAnimationTainted = false;
return CSSParser::parseValueForCustomProperty(
- dummyStyle, "--valid", value, false, nullptr, isAnimationTainted);
+ dummyStyle, "--valid", value, false, nullptr, isAnimationTainted)
+ .didParse;
}
ASSERT(CSSPropertyMetadata::isEnabledProperty(unresolvedProperty));
@@ -55,7 +56,8 @@ bool DOMWindowCSS::supports(const String& property, const String& value) {
// This will return false when !important is present
MutableStylePropertySet* dummyStyle =
MutableStylePropertySet::create(HTMLStandardMode);
- return CSSParser::parseValue(dummyStyle, unresolvedProperty, value, false, 0);
+ return CSSParser::parseValue(dummyStyle, unresolvedProperty, value, false, 0)
+ .didParse;
}
bool DOMWindowCSS::supports(const String& conditionText) {

Powered by Google App Engine
This is Rietveld 408576698