Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Side by Side Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2524303002: Emit console warning when element.animate() keyframe value fails to parse (Closed)
Patch Set: Review changes Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc.
8 * All rights reserved. 8 * All rights reserved.
9 * (C) 2007 Eric Seidel (eric@webkit.org) 9 * (C) 2007 Eric Seidel (eric@webkit.org)
10 * 10 *
(...skipping 3890 matching lines...) Expand 10 before | Expand all | Expand 10 after
3901 bool important) { 3901 bool important) {
3902 DCHECK(isStyledElement()); 3902 DCHECK(isStyledElement());
3903 ensureMutableInlineStyle().setProperty(propertyID, *value, important); 3903 ensureMutableInlineStyle().setProperty(propertyID, *value, important);
3904 inlineStyleChanged(); 3904 inlineStyleChanged();
3905 } 3905 }
3906 3906
3907 bool Element::setInlineStyleProperty(CSSPropertyID propertyID, 3907 bool Element::setInlineStyleProperty(CSSPropertyID propertyID,
3908 const String& value, 3908 const String& value,
3909 bool important) { 3909 bool important) {
3910 DCHECK(isStyledElement()); 3910 DCHECK(isStyledElement());
3911 bool changes = ensureMutableInlineStyle().setProperty( 3911 bool didChange = ensureMutableInlineStyle()
3912 propertyID, value, important, document().elementSheet().contents()); 3912 .setProperty(propertyID, value, important,
3913 if (changes) 3913 document().elementSheet().contents())
3914 .didChange;
3915 if (didChange)
3914 inlineStyleChanged(); 3916 inlineStyleChanged();
3915 return changes; 3917 return didChange;
3916 } 3918 }
3917 3919
3918 bool Element::removeInlineStyleProperty(CSSPropertyID propertyID) { 3920 bool Element::removeInlineStyleProperty(CSSPropertyID propertyID) {
3919 DCHECK(isStyledElement()); 3921 DCHECK(isStyledElement());
3920 if (!inlineStyle()) 3922 if (!inlineStyle())
3921 return false; 3923 return false;
3922 bool changes = ensureMutableInlineStyle().removeProperty(propertyID); 3924 bool didChange = ensureMutableInlineStyle().removeProperty(propertyID);
3923 if (changes) 3925 if (didChange)
3924 inlineStyleChanged(); 3926 inlineStyleChanged();
3925 return changes; 3927 return didChange;
3926 } 3928 }
3927 3929
3928 void Element::removeAllInlineStyleProperties() { 3930 void Element::removeAllInlineStyleProperties() {
3929 DCHECK(isStyledElement()); 3931 DCHECK(isStyledElement());
3930 if (!inlineStyle()) 3932 if (!inlineStyle())
3931 return; 3933 return;
3932 ensureMutableInlineStyle().clear(); 3934 ensureMutableInlineStyle().clear();
3933 inlineStyleChanged(); 3935 inlineStyleChanged();
3934 } 3936 }
3935 3937
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
4087 } 4089 }
4088 4090
4089 DEFINE_TRACE_WRAPPERS(Element) { 4091 DEFINE_TRACE_WRAPPERS(Element) {
4090 if (hasRareData()) { 4092 if (hasRareData()) {
4091 visitor->traceWrappers(elementRareData()); 4093 visitor->traceWrappers(elementRareData());
4092 } 4094 }
4093 ContainerNode::traceWrappers(visitor); 4095 ContainerNode::traceWrappers(visitor);
4094 } 4096 }
4095 4097
4096 } // namespace blink 4098 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp ('k') | third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698