Remove SetSelectedTab() and deprecate unused WebsiteSettingsAction values.

Remove SetSelectedTab() and deprecate unused WebsiteSettingsAction values.

This gets rid of the remaining call to SetSelectedTab(), which has no effect on any platforms anymore.

BUG=646465, 571533, 675239, 675238
Review-Url: https://codereview.chromium.org/2521173004
Cr-Commit-Position: refs/heads/master@{#441749}
Committed: https://chromium.googlesource.com/chromium/src/+/53ce627c8aa95544706c84a918170a8e53f5a20e

[lgarron, 2016-11-22 20:18:01]

lgarron@chromium.org changed reviewers:
+ raymes@chromium.org

[lgarron, 2016-11-22 20:18:01]

raymes@, could you review?

[lgarron, 2016-11-22 20:18:32]

lgarron@chromium.org changed reviewers:
+ isherman@chromium.org

[lgarron, 2016-11-22 20:18:32]

isherman@, could you review histograms.xml?

[raymes, 2016-11-22 22:18:02]

lgtm

[Ilya Sherman, 2016-11-22 22:32:04]

histograms.xml LGTM, thanks

[msw, 2016-11-29 18:26:02]

msw@chromium.org changed reviewers:
+ msw@chromium.org

[msw, 2016-11-29 18:26:03]

drive-by nits

https://codereview.chromium.org/2521173004/diff/1/chrome/browser/ui/website_s...
File chrome/browser/ui/website_settings/website_settings.cc (right):

https://codereview.chromium.org/2521173004/diff/1/chrome/browser/ui/website_s...
chrome/browser/ui/website_settings/website_settings.cc:668:
show_ssl_decision_revoke_button_ = delegate->HasAllowException(url.host());}
nit: fix closing curly brace

https://codereview.chromium.org/2521173004/diff/1/chrome/browser/ui/website_s...
File chrome/browser/ui/website_settings/website_settings.h (right):

https://codereview.chromium.org/2521173004/diff/1/chrome/browser/ui/website_s...
chrome/browser/ui/website_settings/website_settings.h:92: // No longer used;
indicated actions for to the old version of Page Info
nit: "for to"

https://codereview.chromium.org/2521173004/diff/1/chrome/browser/ui/website_s...
chrome/browser/ui/website_settings/website_settings.h:104: // No longer used;
opened the DevTools Security panel
nit: trailing period

[msw, 2016-11-29 18:31:01]

Some more pertinent questions

https://codereview.chromium.org/2521173004/diff/1/chrome/browser/ui/website_s...
File chrome/browser/ui/website_settings/website_settings.h (right):

https://codereview.chromium.org/2521173004/diff/1/chrome/browser/ui/website_s...
chrome/browser/ui/website_settings/website_settings.h:94: //
WEBSITE_SETTINGS_PERMISSIONS_TAB_SELECTED = 1,
Do you need to remove usage from website_settings_unittest.cc?

https://codereview.chromium.org/2521173004/diff/1/chrome/browser/ui/website_s...
chrome/browser/ui/website_settings/website_settings.h:106: //
WEBSITE_SETTINGS_SECURITY_DETAILS_OPENED = 10,
Do you need to remove usage from WebsiteSettingsPopup.java?
(ack CL dep that removes usage from website_settings_popup_view.cc)

[lgarron, 2016-11-29 20:15:46]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 20:16:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 20:51:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 20:51:47]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[lgarron, 2016-12-16 05:39:56]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 05:40:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lgarron, 2016-12-16 05:46:59]

https://codereview.chromium.org/2521173004/diff/1/chrome/browser/ui/website_s...
File chrome/browser/ui/website_settings/website_settings.cc (right):

https://codereview.chromium.org/2521173004/diff/1/chrome/browser/ui/website_s...
chrome/browser/ui/website_settings/website_settings.cc:668:
show_ssl_decision_revoke_button_ = delegate->HasAllowException(url.host());}
On 2016/11/29 at 18:26:03, msw wrote:
> nit: fix closing curly brace

Done.

https://codereview.chromium.org/2521173004/diff/1/chrome/browser/ui/website_s...
File chrome/browser/ui/website_settings/website_settings.h (right):

https://codereview.chromium.org/2521173004/diff/1/chrome/browser/ui/website_s...
chrome/browser/ui/website_settings/website_settings.h:92: // No longer used;
indicated actions for to the old version of Page Info
On 2016/11/29 at 18:26:03, msw wrote:
> nit: "for to"

Done.

https://codereview.chromium.org/2521173004/diff/1/chrome/browser/ui/website_s...
chrome/browser/ui/website_settings/website_settings.h:94: //
WEBSITE_SETTINGS_PERMISSIONS_TAB_SELECTED = 1,
On 2016/11/29 at 18:31:01, msw wrote:
> Do you need to remove usage from website_settings_unittest.cc?

Done.

https://codereview.chromium.org/2521173004/diff/1/chrome/browser/ui/website_s...
chrome/browser/ui/website_settings/website_settings.h:104: // No longer used;
opened the DevTools Security panel
On 2016/11/29 at 18:26:03, msw wrote:
> nit: trailing period

Done.

https://codereview.chromium.org/2521173004/diff/1/chrome/browser/ui/website_s...
chrome/browser/ui/website_settings/website_settings.h:106: //
WEBSITE_SETTINGS_SECURITY_DETAILS_OPENED = 10,
On 2016/11/29 at 18:31:01, msw wrote:
> Do you need to remove usage from WebsiteSettingsPopup.java?
> (ack CL dep that removes usage from website_settings_popup_view.cc)

Hmm. I guess we want that metric to stick around while the old Android Page Info
connection view is still kicking. :-/

I've un-deprecated it in the latest patch.

[lgarron, 2016-12-16 22:40:28]

Description was changed from

==========
Deprecate unused WebsiteSettingsAction values.

This also gets rid of the remaining call to SetSelectedTab(), which has no
effect on any platforms anymore.

BUG=646465, 571533
==========

to

==========
Deprecate unused WebsiteSettingsAction values.

This also gets rid of the remaining call to SetSelectedTab(), which has no
effect on any platforms anymore.

BUG=646465, 571533, 675239
==========

[lgarron, 2016-12-16 22:50:41]

Description was changed from

==========
Deprecate unused WebsiteSettingsAction values.

This also gets rid of the remaining call to SetSelectedTab(), which has no
effect on any platforms anymore.

BUG=646465, 571533, 675239
==========

to

==========
Remove SetSelectedTab() and deprecate unused WebsiteSettingsAction values.

This gets rid of the remaining call to SetSelectedTab(), which has no effect on
any platforms anymore.

BUG=646465, 571533, 675239, 675238
==========

[lgarron, 2016-12-16 23:29:31]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 23:30:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ilya Sherman, 2016-12-17 01:01:08]

histograms.xml lgtm

[commit-bot: I haz the power, 2016-12-17 01:37:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-17 01:37:01]

Dry run: This issue passed the CQ dry run.

[lgarron, 2016-12-17 01:41:30]

The CQ bit was checked by lgarron@chromium.org

[lgarron, 2016-12-17 01:41:31]

The patchset sent to the CQ was uploaded after l-g-t-m from raymes@chromium.org
Link to the patchset: https://codereview.chromium.org/2521173004/#ps40001
(title: "")

[commit-bot: I haz the power, 2016-12-17 01:42:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-17 01:50:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-17 01:50:46]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[lgarron, 2016-12-17 02:20:02]

lgarron@chromium.org changed reviewers:
+ rsesek@chromium.org, tedchoc@chromium.org

[lgarron, 2016-12-17 02:20:03]

tedchoc@, could you review the Android changes (4 files)?
rsesek@, could you review the Cocoa changes (2 files)?

(No hurry, just sending this out on a Friday night 'cause I don't got nothing
better to do for the next hour. :-P)

[Robert Sesek, 2016-12-19 16:56:08]

cocoa/ LGTM

[Ted C, 2016-12-27 20:29:17]

On 2016/12/19 16:56:08, Robert Sesek wrote:
> cocoa/ LGTM

android - lgtm

[lgarron, 2017-01-05 19:51:34]

The CQ bit was checked by lgarron@chromium.org

[commit-bot: I haz the power, 2017-01-05 19:51:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 21:09:22]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483645894870540,
"parent_rev": "b46e558a8922197147fd4a9094029bc753e96261", "commit_rev":
"53ce627c8aa95544706c84a918170a8e53f5a20e"}

[commit-bot: I haz the power, 2017-01-05 21:09:51]

Description was changed from

==========
Remove SetSelectedTab() and deprecate unused WebsiteSettingsAction values.

This gets rid of the remaining call to SetSelectedTab(), which has no effect on
any platforms anymore.

BUG=646465, 571533, 675239, 675238
==========

to

==========
Remove SetSelectedTab() and deprecate unused WebsiteSettingsAction values.

This gets rid of the remaining call to SetSelectedTab(), which has no effect on
any platforms anymore.

BUG=646465, 571533, 675239, 675238

Review-Url: https://codereview.chromium.org/2521173004
Cr-Commit-Position: refs/heads/master@{#441749}
Committed:
https://chromium.googlesource.com/chromium/src/+/53ce627c8aa95544706c84a91817...
==========

[commit-bot: I haz the power, 2017-01-05 21:09:53]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/53ce627c8aa95544706c84a91817...