chrome/browser/ui/views/website_settings/website_settings_popup_view.h - Issue 2521173004: Remove SetSelectedTab() and deprecate unused WebsiteSettingsAction values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/website_settings/website_settings_popup_view.h

Issue 2521173004: Remove SetSelectedTab() and deprecate unused WebsiteSettingsAction values. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm ('k') | chrome/browser/ui/views/website_settings/website_settings_popup_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/website_settings/website_settings_popup_view.h

diff --git a/chrome/browser/ui/views/website_settings/website_settings_popup_view.h b/chrome/browser/ui/views/website_settings/website_settings_popup_view.h

index 7bd93798c3ba5fd396322e2cc7fc12c83eddcc8f..ea6da6aa8a17c5153124f16a151045c272845d12 100644

--- a/chrome/browser/ui/views/website_settings/website_settings_popup_view.h

+++ b/chrome/browser/ui/views/website_settings/website_settings_popup_view.h

@@ -129,8 +129,6 @@ class WebsiteSettingsPopupView : public content::WebContentsObserver,

void SetPermissionInfo(const PermissionInfoList& permission_info_list,

ChosenObjectInfoList chosen_object_info_list) override;

void SetIdentityInfo(const IdentityInfo& identity_info) override;

- // TODO(lgarron): Remove SetSelectedTab() with https://crbug.com/571533

- void SetSelectedTab(TabId tab_id) override;

// Creates the contents of the |site_settings_view_|. The ownership of the

// returned view is transferred to the caller.