Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Unified Diff: chrome/browser/ui/website_settings/website_settings.h

Issue 2521173004: Remove SetSelectedTab() and deprecate unused WebsiteSettingsAction values. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/website_settings/website_settings.h
diff --git a/chrome/browser/ui/website_settings/website_settings.h b/chrome/browser/ui/website_settings/website_settings.h
index 7b9b4aca2e1297e929ed2ec8bc1e9f50b02d7e71..bac969500ba8a723960f0eb8858616fc0eeb29bc 100644
--- a/chrome/browser/ui/website_settings/website_settings.h
+++ b/chrome/browser/ui/website_settings/website_settings.h
@@ -89,9 +89,11 @@ class WebsiteSettings : public TabSpecificContentSettings::SiteDataObserver,
// GENERATED_JAVA_ENUM_PACKAGE: org.chromium.chrome.browser.pageinfo
enum WebsiteSettingsAction {
WEBSITE_SETTINGS_OPENED = 0,
- WEBSITE_SETTINGS_PERMISSIONS_TAB_SELECTED = 1,
- WEBSITE_SETTINGS_CONNECTION_TAB_SELECTED = 2,
- WEBSITE_SETTINGS_CONNECTION_TAB_SHOWN_IMMEDIATELY = 3,
+ // No longer used; indicated actions for the old version of Page Info that
+ // had a "Permissions" tab and a "Connection" tab.
+ // WEBSITE_SETTINGS_PERMISSIONS_TAB_SELECTED = 1,
+ // WEBSITE_SETTINGS_CONNECTION_TAB_SELECTED = 2,
+ // WEBSITE_SETTINGS_CONNECTION_TAB_SHOWN_IMMEDIATELY = 3,
WEBSITE_SETTINGS_COOKIES_DIALOG_OPENED = 4,
WEBSITE_SETTINGS_CHANGED_PERMISSION = 5,
WEBSITE_SETTINGS_CERTIFICATE_DIALOG_OPENED = 6,

Powered by Google App Engine
This is Rietveld 408576698