Remove SetSelectedTab() and deprecate unused WebsiteSettingsAction values.

chrome/browser/ui/website_settings/website_settings.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBSITE_SETTINGS_WEBSITE_SETTINGS_H_
 #define CHROME_BROWSER_UI_WEBSITE_SETTINGS_WEBSITE_SETTINGS_H_
 
 #include "base/macros.h"
 #include "base/strings/string16.h"
 #include "chrome/browser/content_settings/tab_specific_content_settings.h"
@@ skipping 71 matching lines @@
     SITE_IDENTITY_STATUS_MALWARE,
     SITE_IDENTITY_STATUS_SOCIAL_ENGINEERING,
     SITE_IDENTITY_STATUS_UNWANTED_SOFTWARE,
   };
 
   // UMA statistics for WebsiteSettings. Do not reorder or remove existing
   // fields. A Java counterpart will be generated for this enum.
   // GENERATED_JAVA_ENUM_PACKAGE: org.chromium.chrome.browser.pageinfo
   enum WebsiteSettingsAction {
     WEBSITE_SETTINGS_OPENED = 0,
-    WEBSITE_SETTINGS_PERMISSIONS_TAB_SELECTED = 1,
-    WEBSITE_SETTINGS_CONNECTION_TAB_SELECTED = 2,
-    WEBSITE_SETTINGS_CONNECTION_TAB_SHOWN_IMMEDIATELY = 3,
+    // No longer used; indicated actions for to the old version of Page Info

[msw, 2016/11/29 18:26:03]

nit: "for to"

[lgarron, 2016/12/16 05:46:59]

Done.

+    // that had a "Permissions" tab and a "Connection" tab.
+    // WEBSITE_SETTINGS_PERMISSIONS_TAB_SELECTED = 1,

[msw, 2016/11/29 18:31:01]

Do you need to remove usage from website_settings_unittest.cc?

[lgarron, 2016/12/16 05:46:59]

Done.

+    // WEBSITE_SETTINGS_CONNECTION_TAB_SELECTED = 2,
+    // WEBSITE_SETTINGS_CONNECTION_TAB_SHOWN_IMMEDIATELY = 3,
     WEBSITE_SETTINGS_COOKIES_DIALOG_OPENED = 4,
     WEBSITE_SETTINGS_CHANGED_PERMISSION = 5,
     WEBSITE_SETTINGS_CERTIFICATE_DIALOG_OPENED = 6,
     // No longer used; indicated a UI viewer for SCTs.
     // WEBSITE_SETTINGS_TRANSPARENCY_VIEWER_OPENED = 7,
     WEBSITE_SETTINGS_CONNECTION_HELP_OPENED = 8,
     WEBSITE_SETTINGS_SITE_SETTINGS_OPENED = 9,
-    WEBSITE_SETTINGS_SECURITY_DETAILS_OPENED = 10,
+    // No longer used; opened the DevTools Security panel

[msw, 2016/11/29 18:26:03]

nit: trailing period

[lgarron, 2016/12/16 05:46:59]

Done.

+    // (or the certificate viewer, if DevTools was enabled.)
+    // WEBSITE_SETTINGS_SECURITY_DETAILS_OPENED = 10,

[msw, 2016/11/29 18:31:01]

Do you need to remove usage from WebsiteSettingsPopup.java?
(ack CL dep that removes usage from website_settings_popup_view.cc)

[lgarron, 2016/12/16 05:46:59]

Hmm. I guess we want that metric to stick around while the old Android Page Info
connection view is still kicking. :-/

I've un-deprecated it in the latest patch.

     WEBSITE_SETTINGS_COUNT
   };
 
   struct ChooserUIInfo {
     ContentSettingsType content_settings_type;
     ChooserContextBase* (*get_context)(Profile*);
     int blocked_icon_id;
     int allowed_icon_id;
     int label_string_id;
     int delete_tooltip_string_id;
@@ skipping 121 matching lines @@
   bool did_revoke_user_ssl_decisions_;
 
   Profile* profile_;
 
   security_state::SecurityLevel security_level_;
 
   DISALLOW_COPY_AND_ASSIGN(WebsiteSettings);
 };
 
 #endif  // CHROME_BROWSER_UI_WEBSITE_SETTINGS_WEBSITE_SETTINGS_H_