chrome/browser/ui/views/website_settings/website_settings_popup_view.cc - Issue 2521173004: Remove SetSelectedTab() and deprecate unused WebsiteSettingsAction values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

Issue 2521173004: Remove SetSelectedTab() and deprecate unused WebsiteSettingsAction values. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/website_settings/website_settings_popup_view.h ('k') | chrome/browser/ui/website_settings/website_settings.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

diff --git a/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc b/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

index a324f0a761a3d812f912f62f2b9daedaac416a0e..0f41cca26deb5e8271bcfdac66dde4c4abc8180a 100644

--- a/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

+++ b/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

@@ -717,10 +717,6 @@ void WebsiteSettingsPopupView::SetIdentityInfo(

SizeToContents();

}

-void WebsiteSettingsPopupView::SetSelectedTab(TabId tab_id) {

- // TODO(lgarron): Remove this method. (https://crbug.com/571533)

views::View* WebsiteSettingsPopupView::CreateSiteSettingsView() {

views::View* site_settings_view = new views::View();

views::BoxLayout* box_layout =