chrome/browser/ui/android/page_info/website_settings_popup_android.cc - Issue 2521173004: Remove SetSelectedTab() and deprecate unused WebsiteSettingsAction values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/page_info/website_settings_popup_android.cc

Issue 2521173004: Remove SetSelectedTab() and deprecate unused WebsiteSettingsAction values. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/android/page_info/website_settings_popup_android.h ('k') | chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/page_info/website_settings_popup_android.cc

diff --git a/chrome/browser/ui/android/page_info/website_settings_popup_android.cc b/chrome/browser/ui/android/page_info/website_settings_popup_android.cc

index 635464b3eaffeeaefd45b0523bd51c4b2994db83..10be91f18175d49e2637f561b5587acd5ea41d92 100644

--- a/chrome/browser/ui/android/page_info/website_settings_popup_android.cc

+++ b/chrome/browser/ui/android/page_info/website_settings_popup_android.cc

@@ -149,12 +149,6 @@ void WebsiteSettingsPopupAndroid::SetPermissionInfo(

Java_WebsiteSettingsPopup_updatePermissionDisplay(env, popup_jobject_);

}

-void WebsiteSettingsPopupAndroid::SetSelectedTab(

- WebsiteSettingsUI::TabId tab_id) {

- // There's no tab UI on Android - only connection info is shown.

- NOTIMPLEMENTED();

// static

bool WebsiteSettingsPopupAndroid::RegisterWebsiteSettingsPopupAndroid(

JNIEnv* env) {