Issue 2496913002: Fix more -Wsign-compare warnings in heap, mips, base, etc.

Issue 2496913002: Fix more -Wsign-compare warnings in heap, mips, base, etc. (Closed)

Created:
4 years, 1 month ago by ulan

Modified:
4 years, 1 month ago

Reviewers:
Michael Lippautz

CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Fix more -Wsign-compare warnings in heap, mips, base, etc. BUG=v8:5614 Committed: https://crrev.com/f18d56d130685f07a2f3dba1c811669c0084b0d8 Cr-Commit-Position: refs/heads/master@{#40931}

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -43 lines)			Patch
M	src/base/atomic-utils.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cancelable-task.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/heap/gc-tracer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/heap/spaces.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/mips64/simulator-mips64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/perf-jit.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/profiler/sampling-heap-profiler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/heap/test-spaces.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	test/cctest/libplatform/test-tracing.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	test/cctest/test-api.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/cctest/test-conversions.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/cctest/test-global-handles.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	test/unittests/base/atomic-utils-unittest.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	test/unittests/heap/gc-tracer-unittest.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	test/unittests/heap/marking-unittest.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	test/unittests/heap/slot-set-unittest.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	test/unittests/zone/zone-chunk-list-unittest.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 8 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2496913002/1

4 years, 1 month ago (2016-11-11 14:27:57 UTC) #5

commit-bot: I haz the power

4 years, 1 month ago (2016-11-17 22:30:59 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/f18d56d130685f07a2f3dba1c811669c0084b0d8
Cr-Commit-Position: refs/heads/master@{#40931}