Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1096)

Unified Diff: test/unittests/heap/slot-set-unittest.cc

Issue 2496913002: Fix more -Wsign-compare warnings in heap, mips, base, etc. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/unittests/heap/marking-unittest.cc ('k') | test/unittests/zone/zone-chunk-list-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/heap/slot-set-unittest.cc
diff --git a/test/unittests/heap/slot-set-unittest.cc b/test/unittests/heap/slot-set-unittest.cc
index 3b2fbe5ce61f0318d792210cb9bfbd4d6f4a1406..ec905ea2a7313bf4245f24ef901b9d23dd2d20e6 100644
--- a/test/unittests/heap/slot-set-unittest.cc
+++ b/test/unittests/heap/slot-set-unittest.cc
@@ -168,8 +168,8 @@ TEST(TypedSlotSet, Iterate) {
uint32_t j =
static_cast<uint32_t>(reinterpret_cast<uintptr_t>(host_addr));
EXPECT_EQ(i % CLEARED_SLOT, static_cast<uint32_t>(type));
- EXPECT_EQ(0, i % kDelta);
- EXPECT_EQ(0, j % kHostDelta);
+ EXPECT_EQ(0u, i % kDelta);
+ EXPECT_EQ(0u, j % kHostDelta);
++iterated;
return i % 2 == 0 ? KEEP_SLOT : REMOVE_SLOT;
},
@@ -179,7 +179,7 @@ TEST(TypedSlotSet, Iterate) {
set.Iterate(
[&iterated](SlotType type, Address host_addr, Address addr) {
uint32_t i = static_cast<uint32_t>(reinterpret_cast<uintptr_t>(addr));
- EXPECT_EQ(0, i % 2);
+ EXPECT_EQ(0u, i % 2);
++iterated;
return KEEP_SLOT;
},
« no previous file with comments | « test/unittests/heap/marking-unittest.cc ('k') | test/unittests/zone/zone-chunk-list-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698