Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1522)

Unified Diff: test/unittests/base/atomic-utils-unittest.cc

Issue 2496913002: Fix more -Wsign-compare warnings in heap, mips, base, etc. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-global-handles.cc ('k') | test/unittests/heap/gc-tracer-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/base/atomic-utils-unittest.cc
diff --git a/test/unittests/base/atomic-utils-unittest.cc b/test/unittests/base/atomic-utils-unittest.cc
index ad73c4db8a18f34a78017c1221afc201e258524e..48711a2f98ed1bf57eba2eb3f950039e33d60633 100644
--- a/test/unittests/base/atomic-utils-unittest.cc
+++ b/test/unittests/base/atomic-utils-unittest.cc
@@ -16,7 +16,7 @@ TEST(AtomicNumber, Constructor) {
AtomicNumber<size_t> zero_size_t;
AtomicNumber<intptr_t> zero_intptr_t;
EXPECT_EQ(0, zero_int.Value());
- EXPECT_EQ(0U, zero_size_t.Value());
+ EXPECT_EQ(0u, zero_size_t.Value());
EXPECT_EQ(0, zero_intptr_t.Value());
}
@@ -27,7 +27,7 @@ TEST(AtomicNumber, Value) {
AtomicNumber<int> b(-1);
EXPECT_EQ(-1, b.Value());
AtomicNumber<size_t> c(1);
- EXPECT_EQ(1U, c.Value());
+ EXPECT_EQ(1u, c.Value());
AtomicNumber<size_t> d(static_cast<size_t>(-1));
EXPECT_EQ(std::numeric_limits<size_t>::max(), d.Value());
}
@@ -53,7 +53,7 @@ TEST(AtomicNumber, Increment) {
// Should work as decrement as well.
AtomicNumber<size_t> c(1);
c.Increment(-1);
- EXPECT_EQ(0U, c.Value());
+ EXPECT_EQ(0u, c.Value());
c.Increment(-1);
EXPECT_EQ(std::numeric_limits<size_t>::max(), c.Value());
}
@@ -61,7 +61,7 @@ TEST(AtomicNumber, Increment) {
TEST(AtomicNumber, Decrement) {
AtomicNumber<size_t> a(std::numeric_limits<size_t>::max());
a.Increment(1);
- EXPECT_EQ(0, a.Value());
+ EXPECT_EQ(0u, a.Value());
a.Decrement(1);
EXPECT_EQ(std::numeric_limits<size_t>::max(), a.Value());
}
« no previous file with comments | « test/cctest/test-global-handles.cc ('k') | test/unittests/heap/gc-tracer-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698