src/base/atomic-utils.h - Issue 2496913002: Fix more -Wsign-compare warnings in heap, mips, base, etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/base/atomic-utils.h

Issue 2496913002: Fix more -Wsign-compare warnings in heap, mips, base, etc. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/base/atomic-utils.h

diff --git a/src/base/atomic-utils.h b/src/base/atomic-utils.h

index fd9b1b502d573ea62a66c78f3e5daa7c2a27e2f8..f40853c587b09a0dd3c37473e7963ef676d17db6 100644

--- a/src/base/atomic-utils.h

+++ b/src/base/atomic-utils.h

@@ -127,7 +127,7 @@ class AtomicValue {

}

V8_INLINE void SetBits(T bits, T mask) {

- DCHECK_EQ(bits & ~mask, 0);

+ DCHECK_EQ(bits & ~mask, static_cast<T>(0));

T old_value;

T new_value;

do {

« no previous file with comments | « no previous file | src/cancelable-task.cc » ('j') | no next file with comments »