Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: test/cctest/test-conversions.cc

Issue 2496913002: Fix more -Wsign-compare warnings in heap, mips, base, etc. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/cctest/test-api.cc ('k') | test/cctest/test-global-handles.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 407 matching lines...) Expand 10 before | Expand all | Expand 10 after
418 CheckNonArrayIndex(false, "42949672964294967296429496729694966"); 418 CheckNonArrayIndex(false, "42949672964294967296429496729694966");
419 } 419 }
420 420
421 TEST(NoHandlesForTryNumberToSize) { 421 TEST(NoHandlesForTryNumberToSize) {
422 i::Isolate* isolate = CcTest::i_isolate(); 422 i::Isolate* isolate = CcTest::i_isolate();
423 size_t result = 0; 423 size_t result = 0;
424 { 424 {
425 SealHandleScope no_handles(isolate); 425 SealHandleScope no_handles(isolate);
426 Smi* smi = Smi::FromInt(1); 426 Smi* smi = Smi::FromInt(1);
427 CHECK(TryNumberToSize(smi, &result)); 427 CHECK(TryNumberToSize(smi, &result));
428 CHECK_EQ(result, 1); 428 CHECK_EQ(result, 1u);
429 } 429 }
430 result = 0; 430 result = 0;
431 { 431 {
432 HandleScope scope(isolate); 432 HandleScope scope(isolate);
433 Handle<HeapNumber> heap_number1 = isolate->factory()->NewHeapNumber(2.0); 433 Handle<HeapNumber> heap_number1 = isolate->factory()->NewHeapNumber(2.0);
434 { 434 {
435 SealHandleScope no_handles(isolate); 435 SealHandleScope no_handles(isolate);
436 CHECK(TryNumberToSize(*heap_number1, &result)); 436 CHECK(TryNumberToSize(*heap_number1, &result));
437 CHECK_EQ(result, 2); 437 CHECK_EQ(result, 2u);
438 } 438 }
439 Handle<HeapNumber> heap_number2 = isolate->factory()->NewHeapNumber( 439 Handle<HeapNumber> heap_number2 = isolate->factory()->NewHeapNumber(
440 static_cast<double>(std::numeric_limits<size_t>::max()) + 10000.0); 440 static_cast<double>(std::numeric_limits<size_t>::max()) + 10000.0);
441 { 441 {
442 SealHandleScope no_handles(isolate); 442 SealHandleScope no_handles(isolate);
443 CHECK(!TryNumberToSize(*heap_number2, &result)); 443 CHECK(!TryNumberToSize(*heap_number2, &result));
444 } 444 }
445 } 445 }
446 } 446 }
OLDNEW
« no previous file with comments | « test/cctest/test-api.cc ('k') | test/cctest/test-global-handles.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698