Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: test/cctest/test-global-handles.cc

Issue 2496913002: Fix more -Wsign-compare warnings in heap, mips, base, etc. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-conversions.cc ('k') | test/unittests/base/atomic-utils-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-global-handles.cc
diff --git a/test/cctest/test-global-handles.cc b/test/cctest/test-global-handles.cc
index d777432f2fe178278d80ac28b86c78d0747d5fe9..256b74c6164a54f0d633179bfc37f4d0f10c195d 100644
--- a/test/cctest/test-global-handles.cc
+++ b/test/cctest/test-global-handles.cc
@@ -467,8 +467,8 @@ TEST(PhatomHandlesWithoutCallbacks) {
g2.SetWeak();
}
- CHECK_EQ(0, isolate->NumberOfPhantomHandleResetsSinceLastCall());
+ CHECK_EQ(0u, isolate->NumberOfPhantomHandleResetsSinceLastCall());
CcTest::CollectAllAvailableGarbage();
- CHECK_EQ(2, isolate->NumberOfPhantomHandleResetsSinceLastCall());
- CHECK_EQ(0, isolate->NumberOfPhantomHandleResetsSinceLastCall());
+ CHECK_EQ(2u, isolate->NumberOfPhantomHandleResetsSinceLastCall());
+ CHECK_EQ(0u, isolate->NumberOfPhantomHandleResetsSinceLastCall());
}
« no previous file with comments | « test/cctest/test-conversions.cc ('k') | test/unittests/base/atomic-utils-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698