Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1395)

Unified Diff: test/cctest/test-conversions.cc

Issue 2496913002: Fix more -Wsign-compare warnings in heap, mips, base, etc. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-api.cc ('k') | test/cctest/test-global-handles.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-conversions.cc
diff --git a/test/cctest/test-conversions.cc b/test/cctest/test-conversions.cc
index 87dc99c3f00e4c0d11932185e17b5b4ed5a6dc54..2fee58a46d11a96f7370c5522fb541c3bce766f0 100644
--- a/test/cctest/test-conversions.cc
+++ b/test/cctest/test-conversions.cc
@@ -425,7 +425,7 @@ TEST(NoHandlesForTryNumberToSize) {
SealHandleScope no_handles(isolate);
Smi* smi = Smi::FromInt(1);
CHECK(TryNumberToSize(smi, &result));
- CHECK_EQ(result, 1);
+ CHECK_EQ(result, 1u);
}
result = 0;
{
@@ -434,7 +434,7 @@ TEST(NoHandlesForTryNumberToSize) {
{
SealHandleScope no_handles(isolate);
CHECK(TryNumberToSize(*heap_number1, &result));
- CHECK_EQ(result, 2);
+ CHECK_EQ(result, 2u);
}
Handle<HeapNumber> heap_number2 = isolate->factory()->NewHeapNumber(
static_cast<double>(std::numeric_limits<size_t>::max()) + 10000.0);
« no previous file with comments | « test/cctest/test-api.cc ('k') | test/cctest/test-global-handles.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698