Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: src/cancelable-task.cc

Issue 2496913002: Fix more -Wsign-compare warnings in heap, mips, base, etc. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/base/atomic-utils.h ('k') | src/heap/gc-tracer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/cancelable-task.h" 5 #include "src/cancelable-task.h"
6 6
7 #include "src/base/platform/platform.h" 7 #include "src/base/platform/platform.h"
8 #include "src/isolate.h" 8 #include "src/isolate.h"
9 9
10 namespace v8 { 10 namespace v8 {
(...skipping 26 matching lines...) Expand all
37 CHECK(!canceled_); 37 CHECK(!canceled_);
38 cancelable_tasks_[id] = task; 38 cancelable_tasks_[id] = task;
39 return id; 39 return id;
40 } 40 }
41 41
42 42
43 void CancelableTaskManager::RemoveFinishedTask(uint32_t id) { 43 void CancelableTaskManager::RemoveFinishedTask(uint32_t id) {
44 base::LockGuard<base::Mutex> guard(&mutex_); 44 base::LockGuard<base::Mutex> guard(&mutex_);
45 size_t removed = cancelable_tasks_.erase(id); 45 size_t removed = cancelable_tasks_.erase(id);
46 USE(removed); 46 USE(removed);
47 DCHECK_NE(0, removed); 47 DCHECK_NE(0u, removed);
48 cancelable_tasks_barrier_.NotifyOne(); 48 cancelable_tasks_barrier_.NotifyOne();
49 } 49 }
50 50
51 CancelableTaskManager::TryAbortResult CancelableTaskManager::TryAbort( 51 CancelableTaskManager::TryAbortResult CancelableTaskManager::TryAbort(
52 uint32_t id) { 52 uint32_t id) {
53 base::LockGuard<base::Mutex> guard(&mutex_); 53 base::LockGuard<base::Mutex> guard(&mutex_);
54 auto entry = cancelable_tasks_.find(id); 54 auto entry = cancelable_tasks_.find(id);
55 if (entry != cancelable_tasks_.end()) { 55 if (entry != cancelable_tasks_.end()) {
56 Cancelable* value = entry->second; 56 Cancelable* value = entry->second;
57 if (value->Cancel()) { 57 if (value->Cancel()) {
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 96
97 CancelableTask::CancelableTask(Isolate* isolate) 97 CancelableTask::CancelableTask(Isolate* isolate)
98 : Cancelable(isolate->cancelable_task_manager()), isolate_(isolate) {} 98 : Cancelable(isolate->cancelable_task_manager()), isolate_(isolate) {}
99 99
100 100
101 CancelableIdleTask::CancelableIdleTask(Isolate* isolate) 101 CancelableIdleTask::CancelableIdleTask(Isolate* isolate)
102 : Cancelable(isolate->cancelable_task_manager()), isolate_(isolate) {} 102 : Cancelable(isolate->cancelable_task_manager()), isolate_(isolate) {}
103 103
104 } // namespace internal 104 } // namespace internal
105 } // namespace v8 105 } // namespace v8
OLDNEW
« no previous file with comments | « src/base/atomic-utils.h ('k') | src/heap/gc-tracer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698