Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 2484863005: ui: Cleanup class/struct forward declarations (Closed)

Created:
4 years, 1 month ago by jbriance
Modified:
4 years, 1 month ago
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, nektar+watch_chromium.org, dcheng, dmazzoni+watch_chromium.org, extensions-reviews_chromium.org, msw+watch_chromium.org, hcarmona+bubble_chromium.org, Matt Giuca, aboxhall+watch_chromium.org, jam, bruthig+ink_drop_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, je_julie, darin-cc_chromium.org, kalyank, ozone-reviews_chromium.org, derat+watch_chromium.org, tdresser+watch_chromium.org, Peter Beverloo, mlamouri+watch-notifications_chromium.org, yuzo+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, rouslan+bubble_chromium.org, awdf+watch_chromium.org, groby+bubble_chromium.org, Ian Vollick, tfarina, shuchen+watch_chromium.org, dtapuska+chromiumwatch_chromium.org, dtseng+watch_chromium.org, mac-reviews_chromium.org, danakj+watch_chromium.org, James Su
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ui: Cleanup class/struct forward declarations Remove useless class and struct forward declarations, and add missing ones in ui header files. BUG=662195 Committed: https://crrev.com/3d9470fdda9685d803ea3b9c481b6659bb9a9edc Cr-Commit-Position: refs/heads/master@{#431781}

Patch Set 1 #

Patch Set 2 : Fix patch conflict #

Patch Set 3 : Fix another conflict #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -455 lines) Patch
M chrome/browser/ui/views/javascript_app_modal_event_blocker_x11.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/exo/surface.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/clipboard_message_filter.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/common/clipboard_messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/app_window/native_app_window.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/accelerated_widget_mac/accelerated_widget_mac.h View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/accessibility/ax_node.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/android/context_provider_factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/android/delegated_frame_host_android.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/android/resources/crushed_sprite_resource.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/android/resources/resource_manager.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/app_list/app_list_view_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/app_list/presenter/app_list_presenter.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/app_list/presenter/app_list_presenter_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/app_list/search/history_data_store.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/app_list/views/all_apps_tile_item_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/app_list/views/app_list_background.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/app_list/views/app_list_item_view.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/app_list/views/app_list_main_view.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/app_list/views/app_list_view.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/app_list/views/apps_container_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/app_list/views/apps_grid_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/app_list/views/apps_grid_view_delegate.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/app_list/views/apps_grid_view_folder_delegate.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/app_list/views/contents_view.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/app_list/views/folder_header_view.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/app_list/views/search_box_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/app_list/views/search_result_page_view.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/app_list/views/search_result_view.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/app_list/views/speech_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/app_list/views/start_page_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/client/focus_client.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/mus/drag_drop_controller_mus.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/mus/window_compositor_frame_sink.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/aura/mus/window_mus.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/mus/window_tree_client.h View 1 2 2 chunks +0 lines, -5 lines 0 comments Download
M ui/aura/mus/window_tree_client_delegate.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M ui/aura/mus/window_tree_client_observer.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/mus/window_tree_host_mus.h View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/aura/test/aura_test_helper.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/test/mus/test_window_tree_client_setup.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/aura/window.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/aura/window_delegate.h View 2 chunks +0 lines, -8 lines 0 comments Download
M ui/aura/window_event_dispatcher.h View 1 chunk +0 lines, -8 lines 0 comments Download
M ui/aura/window_tree_host_mac.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/aura/window_tree_host_observer.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/window_tree_host_x11.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/base_window.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/base/clipboard/clipboard.h View 2 chunks +0 lines, -14 lines 0 comments Download
M ui/base/clipboard/clipboard_win.h View 1 chunk +10 lines, -0 lines 0 comments Download
M ui/base/cursor/cursor.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/base/default_theme_provider.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/base/dragdrop/drag_utils.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/base/ime/chromeos/ime_keyboard.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/base/ime/chromeos/input_method_manager.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/base/theme_provider.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/chromeos/touch_exploration_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/compositor/clip_recorder.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/compositor/compositor.h View 3 chunks +0 lines, -3 lines 0 comments Download
M ui/compositor/layer.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/compositor/layer_animator.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/compositor/layer_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/compositor/paint_context.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/compositor/paint_recorder.h View 1 chunk +0 lines, -7 lines 0 comments Download
M ui/compositor/scoped_layer_animation_settings.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/compositor/test/in_process_context_factory.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/compositor/transform_recorder.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/display/chromeos/apply_content_protection_task.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/display/chromeos/display_configurator.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/display/manager/display_layout.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/display/test/display_manager_test_api.h View 1 chunk +0 lines, -7 lines 0 comments Download
M ui/events/blink/blink_event_util.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/events/event_dispatcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/event_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/ozone/evdev/input_device_factory_evdev.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/ozone/evdev/input_injector_evdev.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev.h View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/events/platform/platform_event_source.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/platform/x11/x11_hotplug_event_handler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/events/test/event_generator.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/events/test/test_event_target.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/gfx/blit.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/native_widget_types.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/platform_font_linux.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/skbitmap_operations.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/gfx/text_elider.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/gl/gl_egl_api_implementation.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gl/gl_gl_api_implementation.h View 1 chunk +1 line, -6 lines 0 comments Download
M ui/gl/gl_glx_api_implementation.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gl/gl_implementation.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/gl/gl_osmesa_api_implementation.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/gl/gl_surface.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gl/gl_wgl_api_implementation.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gl/test/gl_surface_test_support.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/keyboard/content/keyboard_ui_content.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/message_center/fake_message_center.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/message_center/message_center.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/message_center/message_center_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/message_center/message_center_tray.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/message_center/notification_list.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/message_center/views/message_center_button_bar.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/message_center/views/message_center_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/message_center/views/message_list_view.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/message_center/views/message_view.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/message_center/views/notification_view.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/message_center/views/popup_alignment_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/native_theme/common_theme.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/native_theme/native_theme_base.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/ozone/platform/cast/platform_window_cast.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_device.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_overlay_validator.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_thread.h View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_thread_proxy.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_window.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_surface_factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/hardware_display_plane.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/ozone/platform/drm/gpu/screen_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/host/drm_display_host_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/host/drm_gpu_platform_support_host.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/host/drm_window_host.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/mus_thread_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/platform/wayland/wayland_window.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/public/system_input_injector.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/platform_window/android/platform_window_android.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/platform_window/platform_window.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/platform_window/stub/stub_window.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/platform_window/win/win_window.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/platform_window/x11/x11_cursor_ozone.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/shell_dialogs/select_file_dialog.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/animation/ink_drop.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/views/animation/ink_drop_highlight.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/animation/ink_drop_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/bubble/tray_bubble_view.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/controls/glow_hover_controller.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/controls/menu/menu_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/controls/menu/menu_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/controls/menu/menu_message_loop.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/controls/menu/menu_message_loop_aura.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/controls/menu/menu_runner.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/controls/menu/menu_runner_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/controls/menu/menu_runner_impl_adapter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/controls/menu/menu_runner_impl_interface.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/controls/menu/menu_separator.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/controls/slider.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/controls/textfield/textfield.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/controls/tree/tree_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/corewm/tooltip_aura.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/examples/examples_window.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/focus/focus_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/focus/focus_manager_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/linux_ui/linux_ui.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/mus/drag_drop_client_mus.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/mus/drop_target_mus.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/mus/mus_client.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/mus/native_widget_mus.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/views/mus/text_input_client_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/mus/window_manager_connection.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/mus/window_manager_constants_converters.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/mus/window_tree_host_mus.h View 1 chunk +0 lines, -7 lines 0 comments Download
M ui/views/round_rect_painter.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/selection_controller_delegate.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/style/platform_style.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/test/webview_test_helper.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/test/widget_test.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/view.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/view_targeter.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_cursor_loader_updater.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_factory_ozone.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/x11_move_loop_delegate.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_whole_screen_move_loop.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_window_event_filter.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/native_widget_aura.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/views/widget/native_widget_delegate.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/views/widget/widget.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/widget_observer.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/win/hwnd_message_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/win/hwnd_message_handler_delegate.h View 2 chunks +0 lines, -3 lines 0 comments Download
M ui/web_dialogs/web_dialog_ui.h View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/wm/core/accelerator_filter.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/wm/core/compound_event_filter.h View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/wm/core/shadow_controller.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/wm/core/window_animations.h View 1 chunk +0 lines, -8 lines 0 comments Download
M ui/wm/public/activation_client.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/wm/public/activation_delegate.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/wm/public/window_move_client.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 39 (24 generated)
jbriance
Clean rebased version of my previous messed-up change (https://codereview.chromium.org/2480203002/)
4 years, 1 month ago (2016-11-08 13:07:16 UTC) #2
Avi (use Gerrit)
still lgtm
4 years, 1 month ago (2016-11-08 16:18:38 UTC) #3
asargent_no_longer_on_chrome
extensions/ lgtm
4 years, 1 month ago (2016-11-08 17:54:07 UTC) #10
jbriance
- sdefresne + reveman for components/exo/surface.h
4 years, 1 month ago (2016-11-08 22:27:28 UTC) #14
Nico
lgtm
4 years, 1 month ago (2016-11-09 16:57:04 UTC) #15
sdefresne
components/exo/surface.h lgtm
4 years, 1 month ago (2016-11-10 16:10:47 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2484863005/20001
4 years, 1 month ago (2016-11-10 16:12:30 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/301415)
4 years, 1 month ago (2016-11-10 16:24:47 UTC) #22
jbriance
+ dcheng for "content/common/clipboard_messages.h"
4 years, 1 month ago (2016-11-10 16:25:32 UTC) #24
dcheng
rs lgtm for clipboard_messages.h
4 years, 1 month ago (2016-11-10 22:46:35 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2484863005/20001
4 years, 1 month ago (2016-11-11 08:31:03 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/65926) chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 1 month ago (2016-11-11 08:40:47 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2484863005/40001
4 years, 1 month ago (2016-11-12 08:35:35 UTC) #36
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-12 08:45:24 UTC) #37
commit-bot: I haz the power
4 years, 1 month ago (2016-11-12 08:47:21 UTC) #39
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3d9470fdda9685d803ea3b9c481b6659bb9a9edc
Cr-Commit-Position: refs/heads/master@{#431781}

Powered by Google App Engine
This is Rietveld 408576698