Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Issue 24793002: Thumb2 Backend: Make arithmetic instructions set condition codes by default

Created:
7 years, 2 months ago by rkrithiv
Modified:
6 years, 4 months ago
Reviewers:
ulan, danno
Visibility:
Public.

Description

Thumb2 Backend: Make arithmetic instructions set condition codes by default Most arithmetic instructions can either set the condition codes or not. With Thumb2, most 2-byte encodings require the condition codes to be set. This change allows clients to pass SetCC, LeaveCC, or DontCareCC for arithmetic instructions including MOV. DontCareCC is the default. This is equivalent to SetCC except for some multiplication instructions where it is LeaveCC. test-disasm-arm.cc is disabled. This test need to be rewritten for the new defaults. This is the 10th patch for the Thumb2 Backend. Previous patch: https://codereview.chromium.org/24792002/ Next patch: https://codereview.chromium.org/24795002/ BUG=none TEST=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+374 lines, -288 lines) Patch
M src/arm/assembler-arm.h View 10 chunks +65 lines, -52 lines 0 comments Download
M src/arm/assembler-arm.cc View 21 chunks +116 lines, -98 lines 0 comments Download
M src/arm/assembler-arm-inl.h View 1 chunk +9 lines, -1 line 0 comments Download
M src/arm/assembler-thumb.cc View 34 chunks +121 lines, -89 lines 0 comments Download
M src/arm/assembler-thumb32.cc View 8 chunks +10 lines, -9 lines 0 comments Download
M src/arm/builtins-arm.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/arm/codegen-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm/constants-arm.h View 1 chunk +9 lines, -2 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 2 chunks +8 lines, -8 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 9 chunks +17 lines, -17 lines 0 comments Download
M test/cctest/test-disasm-arm.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698