Update Crashpad to b47bf6c250c6b825dee1c5fbad9152c2c962e828

Update Crashpad to b47bf6c250c6b825dee1c5fbad9152c2c962e828

2d87606bb56b win: Start crashpad_handler by inheriting connection data
             to it
cc0b7deef27d Get VS2013 compilation working again for Crashpad
f735d050c487 Port the util library to Linux
e956a8252fc1 Port the util library to Android
d5a759c900ae Update mini_chromium to 8e8d3cc9a245
d1aafe78ea46 Port the test library and crashpad_test_test to
             Linux/Android
b978b03fa188 Port most of crashpad_util_test to Linux/Android
c2814e251912 Don't throttle explicitly requested uploads
fd751f4708cc Correct StringToUnsignedInt[64]()
e7bd798af438 Update build/test and status documentation to reflect
             Android
e616638c9d87 Replace Rietveld with Gerrit in the developer documentation
47a830465f78 Port the minidump library to Android and ARM
88e3b6b02271 Omit platform-specific assembler source from builds as
             needed
96b9857aceb4 Fix the crashpad_minidump library for 32-bit ARM
c55e49c13d5c doc: Remove errant parenthesis
76ef9b5c2b00 win: Address failure-to-start-handler case for async
             startup
55ba6b67801b break; after handling --initial-client-data on command line
bb7d249d65a1 Partially port the crashpad_client library to Linux/Android
375082098deb mac: Fix tests on 10.12.1
c4cdec3d72a2 Handle non-crashing cases for server failure to start
b47bf6c250c6 Fix tests when running on Win10

Also update .GN files, and adapt Chrome side code for changes in API.
Only the first three files are modified here, the rest are unmodified
from upstream Crashpad repo.

This does not yet make handler startup asynchronous, or move it back to
chrome_elf. Those will be done in smaller followup CLs.

R=mark@chromium.org
TBR=rsesek
BUG=660955, 565063, 656800, 655788
Committed: https://crrev.com/7b9234c4b2a7f4f4fa84c80ecb22d41c54899f6a
Cr-Commit-Position: refs/heads/master@{#429983}

[scottmg, 2016-11-03 21:09:18]

Description was changed from

==========
Update Crashpad to b47bf6c250c6b825dee1c5fbad9152c2c962e828

2d87606bb56b win: Start crashpad_handler by inheriting connection data
             to it
cc0b7deef27d Get VS2013 compilation working again for Crashpad
f735d050c487 Port the util library to Linux
e956a8252fc1 Port the util library to Android
d5a759c900ae Update mini_chromium to 8e8d3cc9a245
d1aafe78ea46 Port the test library and crashpad_test_test to
             Linux/Android
b978b03fa188 Port most of crashpad_util_test to Linux/Android
c2814e251912 Don't throttle explicitly requested uploads
fd751f4708cc Correct StringToUnsignedInt[64]()
e7bd798af438 Update build/test and status documentation to reflect
             Android
e616638c9d87 Replace Rietveld with Gerrit in the developer documentation
47a830465f78 Port the minidump library to Android and ARM
88e3b6b02271 Omit platform-specific assembler source from builds as
             needed
96b9857aceb4 Fix the crashpad_minidump library for 32-bit ARM
c55e49c13d5c doc: Remove errant parenthesis
76ef9b5c2b00 win: Address failure-to-start-handler case for async
             startup
55ba6b67801b break; after handling --initial-client-data on command line
bb7d249d65a1 Partially port the crashpad_client library to Linux/Android
375082098deb mac: Fix tests on 10.12.1
c4cdec3d72a2 Handle non-crashing cases for server failure to start
b47bf6c250c6 Fix tests when running on Win10

Also update .GN files, and adapt Chrome side code for changes in API.

R=mark@chromium.org
BUG=660955,565063,656800,655788
==========

to

==========
Update Crashpad to b47bf6c250c6b825dee1c5fbad9152c2c962e828

2d87606bb56b win: Start crashpad_handler by inheriting connection data
             to it
cc0b7deef27d Get VS2013 compilation working again for Crashpad
f735d050c487 Port the util library to Linux
e956a8252fc1 Port the util library to Android
d5a759c900ae Update mini_chromium to 8e8d3cc9a245
d1aafe78ea46 Port the test library and crashpad_test_test to
             Linux/Android
b978b03fa188 Port most of crashpad_util_test to Linux/Android
c2814e251912 Don't throttle explicitly requested uploads
fd751f4708cc Correct StringToUnsignedInt[64]()
e7bd798af438 Update build/test and status documentation to reflect
             Android
e616638c9d87 Replace Rietveld with Gerrit in the developer documentation
47a830465f78 Port the minidump library to Android and ARM
88e3b6b02271 Omit platform-specific assembler source from builds as
             needed
96b9857aceb4 Fix the crashpad_minidump library for 32-bit ARM
c55e49c13d5c doc: Remove errant parenthesis
76ef9b5c2b00 win: Address failure-to-start-handler case for async
             startup
55ba6b67801b break; after handling --initial-client-data on command line
bb7d249d65a1 Partially port the crashpad_client library to Linux/Android
375082098deb mac: Fix tests on 10.12.1
c4cdec3d72a2 Handle non-crashing cases for server failure to start
b47bf6c250c6 Fix tests when running on Win10

Also update .GN files, and adapt Chrome side code for changes in API.

R=mark@chromium.org
BUG=660955,565063,656800,655788
==========

[scottmg, 2016-11-03 21:12:39]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[scottmg, 2016-11-03 21:13:22]

Description was changed from

==========
Update Crashpad to b47bf6c250c6b825dee1c5fbad9152c2c962e828

2d87606bb56b win: Start crashpad_handler by inheriting connection data
             to it
cc0b7deef27d Get VS2013 compilation working again for Crashpad
f735d050c487 Port the util library to Linux
e956a8252fc1 Port the util library to Android
d5a759c900ae Update mini_chromium to 8e8d3cc9a245
d1aafe78ea46 Port the test library and crashpad_test_test to
             Linux/Android
b978b03fa188 Port most of crashpad_util_test to Linux/Android
c2814e251912 Don't throttle explicitly requested uploads
fd751f4708cc Correct StringToUnsignedInt[64]()
e7bd798af438 Update build/test and status documentation to reflect
             Android
e616638c9d87 Replace Rietveld with Gerrit in the developer documentation
47a830465f78 Port the minidump library to Android and ARM
88e3b6b02271 Omit platform-specific assembler source from builds as
             needed
96b9857aceb4 Fix the crashpad_minidump library for 32-bit ARM
c55e49c13d5c doc: Remove errant parenthesis
76ef9b5c2b00 win: Address failure-to-start-handler case for async
             startup
55ba6b67801b break; after handling --initial-client-data on command line
bb7d249d65a1 Partially port the crashpad_client library to Linux/Android
375082098deb mac: Fix tests on 10.12.1
c4cdec3d72a2 Handle non-crashing cases for server failure to start
b47bf6c250c6 Fix tests when running on Win10

Also update .GN files, and adapt Chrome side code for changes in API.

R=mark@chromium.org
BUG=660955,565063,656800,655788
==========

to

==========
Update Crashpad to b47bf6c250c6b825dee1c5fbad9152c2c962e828

2d87606bb56b win: Start crashpad_handler by inheriting connection data
             to it
cc0b7deef27d Get VS2013 compilation working again for Crashpad
f735d050c487 Port the util library to Linux
e956a8252fc1 Port the util library to Android
d5a759c900ae Update mini_chromium to 8e8d3cc9a245
d1aafe78ea46 Port the test library and crashpad_test_test to
             Linux/Android
b978b03fa188 Port most of crashpad_util_test to Linux/Android
c2814e251912 Don't throttle explicitly requested uploads
fd751f4708cc Correct StringToUnsignedInt[64]()
e7bd798af438 Update build/test and status documentation to reflect
             Android
e616638c9d87 Replace Rietveld with Gerrit in the developer documentation
47a830465f78 Port the minidump library to Android and ARM
88e3b6b02271 Omit platform-specific assembler source from builds as
             needed
96b9857aceb4 Fix the crashpad_minidump library for 32-bit ARM
c55e49c13d5c doc: Remove errant parenthesis
76ef9b5c2b00 win: Address failure-to-start-handler case for async
             startup
55ba6b67801b break; after handling --initial-client-data on command line
bb7d249d65a1 Partially port the crashpad_client library to Linux/Android
375082098deb mac: Fix tests on 10.12.1
c4cdec3d72a2 Handle non-crashing cases for server failure to start
b47bf6c250c6 Fix tests when running on Win10

Also update .GN files, and adapt Chrome side code for changes in API.
Only the first three files are modified here, the rest are unmodified
from upstream Crashpad repo.

R=mark@chromium.org
BUG=660955,565063,656800,655788
==========

[commit-bot: I haz the power, 2016-11-03 21:13:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 21:25:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 21:25:09]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Mark Mentovai, 2016-11-03 21:35:30]

,   !

https://codereview.chromium.org/2478633002/diff/20001/components/crash/conten...
File components/crash/content/app/crashpad_mac.mm (right):

https://codereview.chromium.org/2478633002/diff/20001/components/crash/conten...
components/crash/content/app/crashpad_mac.mm:105: // StartHandler() call
UseSystemDefaultHandler() in that case to drop the
Removed too many words here.

https://codereview.chromium.org/2478633002/diff/20001/components/crash/conten...
File components/crash/content/app/crashpad_win.cc (right):

https://codereview.chromium.org/2478633002/diff/20001/components/crash/conten...
components/crash/content/app/crashpad_win.cc:123: arguments, false, true);
Where's the thing that waits to make sure that this worked before starting any
child processes?

https://codereview.chromium.org/2478633002/diff/20001/components/crash/conten...
components/crash/content/app/crashpad_win.cc:132: bool result =
env->GetVar(kPipeNameVar, &pipe_name_utf8);
Is there even any reason to have |result| now?

[Mark Mentovai, 2016-11-03 21:45:02]

Do you maybe want to land this in two parts? One for the roll and to adapt
to the interface changes, and another to turn on the asynchronous start.
That way, we'll be less likely to have the whole roll reverted if there's a
problem with asynchronous starting.

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[scottmg, 2016-11-03 21:49:17]

On 2016/11/03 21:45:02, Mark Mentovai wrote:
> Do you maybe want to land this in two parts? One for the roll and to adapt
> to the interface changes, and another to turn on the asynchronous start.
> That way, we'll be less likely to have the whole roll reverted if there's a
> problem with asynchronous starting.

Yeah, good idea.

[scottmg, 2016-11-03 21:59:55]

Description was changed from

==========
Update Crashpad to b47bf6c250c6b825dee1c5fbad9152c2c962e828

2d87606bb56b win: Start crashpad_handler by inheriting connection data
             to it
cc0b7deef27d Get VS2013 compilation working again for Crashpad
f735d050c487 Port the util library to Linux
e956a8252fc1 Port the util library to Android
d5a759c900ae Update mini_chromium to 8e8d3cc9a245
d1aafe78ea46 Port the test library and crashpad_test_test to
             Linux/Android
b978b03fa188 Port most of crashpad_util_test to Linux/Android
c2814e251912 Don't throttle explicitly requested uploads
fd751f4708cc Correct StringToUnsignedInt[64]()
e7bd798af438 Update build/test and status documentation to reflect
             Android
e616638c9d87 Replace Rietveld with Gerrit in the developer documentation
47a830465f78 Port the minidump library to Android and ARM
88e3b6b02271 Omit platform-specific assembler source from builds as
             needed
96b9857aceb4 Fix the crashpad_minidump library for 32-bit ARM
c55e49c13d5c doc: Remove errant parenthesis
76ef9b5c2b00 win: Address failure-to-start-handler case for async
             startup
55ba6b67801b break; after handling --initial-client-data on command line
bb7d249d65a1 Partially port the crashpad_client library to Linux/Android
375082098deb mac: Fix tests on 10.12.1
c4cdec3d72a2 Handle non-crashing cases for server failure to start
b47bf6c250c6 Fix tests when running on Win10

Also update .GN files, and adapt Chrome side code for changes in API.
Only the first three files are modified here, the rest are unmodified
from upstream Crashpad repo.

R=mark@chromium.org
BUG=660955,565063,656800,655788
==========

to

==========
Update Crashpad to b47bf6c250c6b825dee1c5fbad9152c2c962e828

2d87606bb56b win: Start crashpad_handler by inheriting connection data
             to it
cc0b7deef27d Get VS2013 compilation working again for Crashpad
f735d050c487 Port the util library to Linux
e956a8252fc1 Port the util library to Android
d5a759c900ae Update mini_chromium to 8e8d3cc9a245
d1aafe78ea46 Port the test library and crashpad_test_test to
             Linux/Android
b978b03fa188 Port most of crashpad_util_test to Linux/Android
c2814e251912 Don't throttle explicitly requested uploads
fd751f4708cc Correct StringToUnsignedInt[64]()
e7bd798af438 Update build/test and status documentation to reflect
             Android
e616638c9d87 Replace Rietveld with Gerrit in the developer documentation
47a830465f78 Port the minidump library to Android and ARM
88e3b6b02271 Omit platform-specific assembler source from builds as
             needed
96b9857aceb4 Fix the crashpad_minidump library for 32-bit ARM
c55e49c13d5c doc: Remove errant parenthesis
76ef9b5c2b00 win: Address failure-to-start-handler case for async
             startup
55ba6b67801b break; after handling --initial-client-data on command line
bb7d249d65a1 Partially port the crashpad_client library to Linux/Android
375082098deb mac: Fix tests on 10.12.1
c4cdec3d72a2 Handle non-crashing cases for server failure to start
b47bf6c250c6 Fix tests when running on Win10

Also update .GN files, and adapt Chrome side code for changes in API.
Only the first three files are modified here, the rest are unmodified
from upstream Crashpad repo.

This does not yet make handler startup asynchronous, or move it back to
chrome_elf. Those will be done in a smaller followup CLs.

R=mark@chromium.org
BUG=660955,565063,656800,655788
==========

[scottmg, 2016-11-03 22:01:08]

https://codereview.chromium.org/2478633002/diff/20001/components/crash/conten...
File components/crash/content/app/crashpad_mac.mm (right):

https://codereview.chromium.org/2478633002/diff/20001/components/crash/conten...
components/crash/content/app/crashpad_mac.mm:105: // StartHandler() call
UseSystemDefaultHandler() in that case to drop the
On 2016/11/03 21:35:30, Mark Mentovai wrote:
> Removed too many words here.

Done.

https://codereview.chromium.org/2478633002/diff/20001/components/crash/conten...
File components/crash/content/app/crashpad_win.cc (right):

https://codereview.chromium.org/2478633002/diff/20001/components/crash/conten...
components/crash/content/app/crashpad_win.cc:123: arguments, false, true);
On 2016/11/03 21:35:30, Mark Mentovai wrote:
> Where's the thing that waits to make sure that this worked before starting any
> child processes?

Oops, forgot about that. Just to confirm we agree on the details, that's not
strictly necessary for correctness, only to report a helpful LOG, right?
StartHandler() has created the pipe by the time it returns, and
registration_protocol_win.cc in the child processes will either: 1) retry
forever while the pipe exists (and the pipe will only exist while the handler
does), or 2) return false because the pipe no longer exists (and so won't block
the child from normal operation).

But per your suggestion to avoid churn in case of revert, kept startup
synchronous for this roll, so deferring this to a followup anyway.

https://codereview.chromium.org/2478633002/diff/20001/components/crash/conten...
components/crash/content/app/crashpad_win.cc:132: bool result =
env->GetVar(kPipeNameVar, &pipe_name_utf8);
On 2016/11/03 21:35:30, Mark Mentovai wrote:
> Is there even any reason to have |result| now?

Done.

[scottmg, 2016-11-03 22:04:26]

Description was changed from

==========
Update Crashpad to b47bf6c250c6b825dee1c5fbad9152c2c962e828

2d87606bb56b win: Start crashpad_handler by inheriting connection data
             to it
cc0b7deef27d Get VS2013 compilation working again for Crashpad
f735d050c487 Port the util library to Linux
e956a8252fc1 Port the util library to Android
d5a759c900ae Update mini_chromium to 8e8d3cc9a245
d1aafe78ea46 Port the test library and crashpad_test_test to
             Linux/Android
b978b03fa188 Port most of crashpad_util_test to Linux/Android
c2814e251912 Don't throttle explicitly requested uploads
fd751f4708cc Correct StringToUnsignedInt[64]()
e7bd798af438 Update build/test and status documentation to reflect
             Android
e616638c9d87 Replace Rietveld with Gerrit in the developer documentation
47a830465f78 Port the minidump library to Android and ARM
88e3b6b02271 Omit platform-specific assembler source from builds as
             needed
96b9857aceb4 Fix the crashpad_minidump library for 32-bit ARM
c55e49c13d5c doc: Remove errant parenthesis
76ef9b5c2b00 win: Address failure-to-start-handler case for async
             startup
55ba6b67801b break; after handling --initial-client-data on command line
bb7d249d65a1 Partially port the crashpad_client library to Linux/Android
375082098deb mac: Fix tests on 10.12.1
c4cdec3d72a2 Handle non-crashing cases for server failure to start
b47bf6c250c6 Fix tests when running on Win10

Also update .GN files, and adapt Chrome side code for changes in API.
Only the first three files are modified here, the rest are unmodified
from upstream Crashpad repo.

This does not yet make handler startup asynchronous, or move it back to
chrome_elf. Those will be done in a smaller followup CLs.

R=mark@chromium.org
BUG=660955,565063,656800,655788
==========

to

==========
Update Crashpad to b47bf6c250c6b825dee1c5fbad9152c2c962e828

2d87606bb56b win: Start crashpad_handler by inheriting connection data
             to it
cc0b7deef27d Get VS2013 compilation working again for Crashpad
f735d050c487 Port the util library to Linux
e956a8252fc1 Port the util library to Android
d5a759c900ae Update mini_chromium to 8e8d3cc9a245
d1aafe78ea46 Port the test library and crashpad_test_test to
             Linux/Android
b978b03fa188 Port most of crashpad_util_test to Linux/Android
c2814e251912 Don't throttle explicitly requested uploads
fd751f4708cc Correct StringToUnsignedInt[64]()
e7bd798af438 Update build/test and status documentation to reflect
             Android
e616638c9d87 Replace Rietveld with Gerrit in the developer documentation
47a830465f78 Port the minidump library to Android and ARM
88e3b6b02271 Omit platform-specific assembler source from builds as
             needed
96b9857aceb4 Fix the crashpad_minidump library for 32-bit ARM
c55e49c13d5c doc: Remove errant parenthesis
76ef9b5c2b00 win: Address failure-to-start-handler case for async
             startup
55ba6b67801b break; after handling --initial-client-data on command line
bb7d249d65a1 Partially port the crashpad_client library to Linux/Android
375082098deb mac: Fix tests on 10.12.1
c4cdec3d72a2 Handle non-crashing cases for server failure to start
b47bf6c250c6 Fix tests when running on Win10

Also update .GN files, and adapt Chrome side code for changes in API.
Only the first three files are modified here, the rest are unmodified
from upstream Crashpad repo.

This does not yet make handler startup asynchronous, or move it back to
chrome_elf. Those will be done in smaller followup CLs.

R=mark@chromium.org
BUG=660955,565063,656800,655788
==========

[Mark Mentovai, 2016-11-03 22:12:51]

LGTM!

The weird punctuation you saw before was “wow, we’ve been busy.” Because you
apparently can enter punctuation in this here box from Chrome on Android, but
you can’t enter letters.

https://codereview.chromium.org/2478633002/diff/60001/components/crash/conten...
File components/crash/content/app/crashpad_mac.mm (right):

https://codereview.chromium.org/2478633002/diff/60001/components/crash/conten...
components/crash/content/app/crashpad_mac.mm:105: // StartHandler() failed, call
UseSystemDefaultHandler() in that case to
Well, I guess “in that case“ is the bit hat we could have lost.

[scottmg, 2016-11-03 22:19:35]

On 2016/11/03 22:12:51, Mark Mentovai wrote:
> LGTM!
> 
> The weird punctuation you saw before was “wow, we’ve been busy.” Because you

Yeah, great to see Android/Linux get started! I was wishing I'd dumped other
work to join in as I started to see those changes stream by.

> apparently can enter punctuation in this here box from Chrome on Android, but
> you can’t enter letters.
> 
>
https://codereview.chromium.org/2478633002/diff/60001/components/crash/conten...
> File components/crash/content/app/crashpad_mac.mm (right):
> 
>
https://codereview.chromium.org/2478633002/diff/60001/components/crash/conten...
> components/crash/content/app/crashpad_mac.mm:105: // StartHandler() failed,
call
> UseSystemDefaultHandler() in that case to
> Well, I guess “in that case“ is the bit hat we could have lost.

[scottmg, 2016-11-03 22:19:42]

https://codereview.chromium.org/2478633002/diff/60001/components/crash/conten...
File components/crash/content/app/crashpad_mac.mm (right):

https://codereview.chromium.org/2478633002/diff/60001/components/crash/conten...
components/crash/content/app/crashpad_mac.mm:105: // StartHandler() failed, call
UseSystemDefaultHandler() in that case to
On 2016/11/03 22:12:50, Mark Mentovai wrote:
> Well, I guess “in that case“ is the bit hat we could have lost.

Yeah, that's a bit wordy. Done.

[scottmg, 2016-11-03 22:20:42]

scottmg@chromium.org changed reviewers:
+ rsesek@chromium.org

[scottmg, 2016-11-03 22:20:43]

+rsesek

Could you stamp for
third_party/crashpad/crashpad/util/thread/thread_log_messages.cc as an
//ipc/SECURITY_OWNERS and vaguely interested party to avoid the bogus presubmit
message too please? (It thinks
third_party/crashpad/crashpad/util/thread/thread_log_messages.cc is an IPC
file.)

[scottmg, 2016-11-03 22:20:55]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 22:21:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Robert Sesek, 2016-11-03 22:29:01]

stampity lgtm

[scottmg, 2016-11-03 22:38:58]

The CQ bit was unchecked by scottmg@chromium.org

[scottmg, 2016-11-03 22:39:07]

The CQ bit was checked by scottmg@chromium.org

[scottmg, 2016-11-03 22:39:07]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org
Link to the patchset: https://codereview.chromium.org/2478633002/#ps80001
(title: "mac comment 2")

[commit-bot: I haz the power, 2016-11-03 22:39:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mark Mentovai, 2016-11-03 22:44:32]

scottmg wrote:
> Yeah, great to see Android/Linux get started! I was wishing I'd dumped other
> work to join in as I started to see those changes stream by.

If you can dump your other work, I’d love to have you pitch in!

[commit-bot: I haz the power, 2016-11-03 23:37:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 23:37:22]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[scottmg, 2016-11-03 23:49:59]

Stupid thing really wants an OWNERS file in
third_party/crashpad/crashpad/util/thread/, but I'm not doing that.
https://codereview.chromium.org/2477973002.

[Mark Mentovai, 2016-11-04 00:25:06]

Set TBR= to ram this in, and file a bug against PRESUBMIT?

[scottmg, 2016-11-04 01:16:32]

Description was changed from

==========
Update Crashpad to b47bf6c250c6b825dee1c5fbad9152c2c962e828

2d87606bb56b win: Start crashpad_handler by inheriting connection data
             to it
cc0b7deef27d Get VS2013 compilation working again for Crashpad
f735d050c487 Port the util library to Linux
e956a8252fc1 Port the util library to Android
d5a759c900ae Update mini_chromium to 8e8d3cc9a245
d1aafe78ea46 Port the test library and crashpad_test_test to
             Linux/Android
b978b03fa188 Port most of crashpad_util_test to Linux/Android
c2814e251912 Don't throttle explicitly requested uploads
fd751f4708cc Correct StringToUnsignedInt[64]()
e7bd798af438 Update build/test and status documentation to reflect
             Android
e616638c9d87 Replace Rietveld with Gerrit in the developer documentation
47a830465f78 Port the minidump library to Android and ARM
88e3b6b02271 Omit platform-specific assembler source from builds as
             needed
96b9857aceb4 Fix the crashpad_minidump library for 32-bit ARM
c55e49c13d5c doc: Remove errant parenthesis
76ef9b5c2b00 win: Address failure-to-start-handler case for async
             startup
55ba6b67801b break; after handling --initial-client-data on command line
bb7d249d65a1 Partially port the crashpad_client library to Linux/Android
375082098deb mac: Fix tests on 10.12.1
c4cdec3d72a2 Handle non-crashing cases for server failure to start
b47bf6c250c6 Fix tests when running on Win10

Also update .GN files, and adapt Chrome side code for changes in API.
Only the first three files are modified here, the rest are unmodified
from upstream Crashpad repo.

This does not yet make handler startup asynchronous, or move it back to
chrome_elf. Those will be done in smaller followup CLs.

R=mark@chromium.org
BUG=660955,565063,656800,655788
==========

to

==========
Update Crashpad to b47bf6c250c6b825dee1c5fbad9152c2c962e828

2d87606bb56b win: Start crashpad_handler by inheriting connection data
             to it
cc0b7deef27d Get VS2013 compilation working again for Crashpad
f735d050c487 Port the util library to Linux
e956a8252fc1 Port the util library to Android
d5a759c900ae Update mini_chromium to 8e8d3cc9a245
d1aafe78ea46 Port the test library and crashpad_test_test to
             Linux/Android
b978b03fa188 Port most of crashpad_util_test to Linux/Android
c2814e251912 Don't throttle explicitly requested uploads
fd751f4708cc Correct StringToUnsignedInt[64]()
e7bd798af438 Update build/test and status documentation to reflect
             Android
e616638c9d87 Replace Rietveld with Gerrit in the developer documentation
47a830465f78 Port the minidump library to Android and ARM
88e3b6b02271 Omit platform-specific assembler source from builds as
             needed
96b9857aceb4 Fix the crashpad_minidump library for 32-bit ARM
c55e49c13d5c doc: Remove errant parenthesis
76ef9b5c2b00 win: Address failure-to-start-handler case for async
             startup
55ba6b67801b break; after handling --initial-client-data on command line
bb7d249d65a1 Partially port the crashpad_client library to Linux/Android
375082098deb mac: Fix tests on 10.12.1
c4cdec3d72a2 Handle non-crashing cases for server failure to start
b47bf6c250c6 Fix tests when running on Win10

Also update .GN files, and adapt Chrome side code for changes in API.
Only the first three files are modified here, the rest are unmodified
from upstream Crashpad repo.

This does not yet make handler startup asynchronous, or move it back to
chrome_elf. Those will be done in smaller followup CLs.

R=mark@chromium.org
TBR=rsesek
BUG=660955,565063,656800,655788
==========

[scottmg, 2016-11-04 01:16:42]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2016-11-04 01:17:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 01:34:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 01:34:04]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[scottmg, 2016-11-04 18:25:18]

On 2016/11/04 01:34:04, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

PRESUBMIT is fixed now.

[scottmg, 2016-11-04 18:25:25]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2016-11-04 18:26:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 19:51:58]

Description was changed from

==========
Update Crashpad to b47bf6c250c6b825dee1c5fbad9152c2c962e828

2d87606bb56b win: Start crashpad_handler by inheriting connection data
             to it
cc0b7deef27d Get VS2013 compilation working again for Crashpad
f735d050c487 Port the util library to Linux
e956a8252fc1 Port the util library to Android
d5a759c900ae Update mini_chromium to 8e8d3cc9a245
d1aafe78ea46 Port the test library and crashpad_test_test to
             Linux/Android
b978b03fa188 Port most of crashpad_util_test to Linux/Android
c2814e251912 Don't throttle explicitly requested uploads
fd751f4708cc Correct StringToUnsignedInt[64]()
e7bd798af438 Update build/test and status documentation to reflect
             Android
e616638c9d87 Replace Rietveld with Gerrit in the developer documentation
47a830465f78 Port the minidump library to Android and ARM
88e3b6b02271 Omit platform-specific assembler source from builds as
             needed
96b9857aceb4 Fix the crashpad_minidump library for 32-bit ARM
c55e49c13d5c doc: Remove errant parenthesis
76ef9b5c2b00 win: Address failure-to-start-handler case for async
             startup
55ba6b67801b break; after handling --initial-client-data on command line
bb7d249d65a1 Partially port the crashpad_client library to Linux/Android
375082098deb mac: Fix tests on 10.12.1
c4cdec3d72a2 Handle non-crashing cases for server failure to start
b47bf6c250c6 Fix tests when running on Win10

Also update .GN files, and adapt Chrome side code for changes in API.
Only the first three files are modified here, the rest are unmodified
from upstream Crashpad repo.

This does not yet make handler startup asynchronous, or move it back to
chrome_elf. Those will be done in smaller followup CLs.

R=mark@chromium.org
TBR=rsesek
BUG=660955,565063,656800,655788
==========

to

==========
Update Crashpad to b47bf6c250c6b825dee1c5fbad9152c2c962e828

2d87606bb56b win: Start crashpad_handler by inheriting connection data
             to it
cc0b7deef27d Get VS2013 compilation working again for Crashpad
f735d050c487 Port the util library to Linux
e956a8252fc1 Port the util library to Android
d5a759c900ae Update mini_chromium to 8e8d3cc9a245
d1aafe78ea46 Port the test library and crashpad_test_test to
             Linux/Android
b978b03fa188 Port most of crashpad_util_test to Linux/Android
c2814e251912 Don't throttle explicitly requested uploads
fd751f4708cc Correct StringToUnsignedInt[64]()
e7bd798af438 Update build/test and status documentation to reflect
             Android
e616638c9d87 Replace Rietveld with Gerrit in the developer documentation
47a830465f78 Port the minidump library to Android and ARM
88e3b6b02271 Omit platform-specific assembler source from builds as
             needed
96b9857aceb4 Fix the crashpad_minidump library for 32-bit ARM
c55e49c13d5c doc: Remove errant parenthesis
76ef9b5c2b00 win: Address failure-to-start-handler case for async
             startup
55ba6b67801b break; after handling --initial-client-data on command line
bb7d249d65a1 Partially port the crashpad_client library to Linux/Android
375082098deb mac: Fix tests on 10.12.1
c4cdec3d72a2 Handle non-crashing cases for server failure to start
b47bf6c250c6 Fix tests when running on Win10

Also update .GN files, and adapt Chrome side code for changes in API.
Only the first three files are modified here, the rest are unmodified
from upstream Crashpad repo.

This does not yet make handler startup asynchronous, or move it back to
chrome_elf. Those will be done in smaller followup CLs.

R=mark@chromium.org
TBR=rsesek
BUG=660955,565063,656800,655788
==========

[commit-bot: I haz the power, 2016-11-04 19:51:59]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-11-04 20:00:35]

Description was changed from

==========
Update Crashpad to b47bf6c250c6b825dee1c5fbad9152c2c962e828

2d87606bb56b win: Start crashpad_handler by inheriting connection data
             to it
cc0b7deef27d Get VS2013 compilation working again for Crashpad
f735d050c487 Port the util library to Linux
e956a8252fc1 Port the util library to Android
d5a759c900ae Update mini_chromium to 8e8d3cc9a245
d1aafe78ea46 Port the test library and crashpad_test_test to
             Linux/Android
b978b03fa188 Port most of crashpad_util_test to Linux/Android
c2814e251912 Don't throttle explicitly requested uploads
fd751f4708cc Correct StringToUnsignedInt[64]()
e7bd798af438 Update build/test and status documentation to reflect
             Android
e616638c9d87 Replace Rietveld with Gerrit in the developer documentation
47a830465f78 Port the minidump library to Android and ARM
88e3b6b02271 Omit platform-specific assembler source from builds as
             needed
96b9857aceb4 Fix the crashpad_minidump library for 32-bit ARM
c55e49c13d5c doc: Remove errant parenthesis
76ef9b5c2b00 win: Address failure-to-start-handler case for async
             startup
55ba6b67801b break; after handling --initial-client-data on command line
bb7d249d65a1 Partially port the crashpad_client library to Linux/Android
375082098deb mac: Fix tests on 10.12.1
c4cdec3d72a2 Handle non-crashing cases for server failure to start
b47bf6c250c6 Fix tests when running on Win10

Also update .GN files, and adapt Chrome side code for changes in API.
Only the first three files are modified here, the rest are unmodified
from upstream Crashpad repo.

This does not yet make handler startup asynchronous, or move it back to
chrome_elf. Those will be done in smaller followup CLs.

R=mark@chromium.org
TBR=rsesek
BUG=660955,565063,656800,655788
==========

to

==========
Update Crashpad to b47bf6c250c6b825dee1c5fbad9152c2c962e828

2d87606bb56b win: Start crashpad_handler by inheriting connection data
             to it
cc0b7deef27d Get VS2013 compilation working again for Crashpad
f735d050c487 Port the util library to Linux
e956a8252fc1 Port the util library to Android
d5a759c900ae Update mini_chromium to 8e8d3cc9a245
d1aafe78ea46 Port the test library and crashpad_test_test to
             Linux/Android
b978b03fa188 Port most of crashpad_util_test to Linux/Android
c2814e251912 Don't throttle explicitly requested uploads
fd751f4708cc Correct StringToUnsignedInt[64]()
e7bd798af438 Update build/test and status documentation to reflect
             Android
e616638c9d87 Replace Rietveld with Gerrit in the developer documentation
47a830465f78 Port the minidump library to Android and ARM
88e3b6b02271 Omit platform-specific assembler source from builds as
             needed
96b9857aceb4 Fix the crashpad_minidump library for 32-bit ARM
c55e49c13d5c doc: Remove errant parenthesis
76ef9b5c2b00 win: Address failure-to-start-handler case for async
             startup
55ba6b67801b break; after handling --initial-client-data on command line
bb7d249d65a1 Partially port the crashpad_client library to Linux/Android
375082098deb mac: Fix tests on 10.12.1
c4cdec3d72a2 Handle non-crashing cases for server failure to start
b47bf6c250c6 Fix tests when running on Win10

Also update .GN files, and adapt Chrome side code for changes in API.
Only the first three files are modified here, the rest are unmodified
from upstream Crashpad repo.

This does not yet make handler startup asynchronous, or move it back to
chrome_elf. Those will be done in smaller followup CLs.

R=mark@chromium.org
TBR=rsesek
BUG=660955,565063,656800,655788

Committed: https://crrev.com/7b9234c4b2a7f4f4fa84c80ecb22d41c54899f6a
Cr-Commit-Position: refs/heads/master@{#429983}
==========

[commit-bot: I haz the power, 2016-11-04 20:00:36]

Patchset 5 (id:??) landed as
https://crrev.com/7b9234c4b2a7f4f4fa84c80ecb22d41c54899f6a
Cr-Commit-Position: refs/heads/master@{#429983}