Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: third_party/crashpad/crashpad/util/string/split_string_test.cc

Issue 2478633002: Update Crashpad to b47bf6c250c6b825dee1c5fbad9152c2c962e828 (Closed)
Patch Set: mac comment 2 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/util/string/split_string_test.cc
diff --git a/third_party/crashpad/crashpad/util/string/split_string_test.cc b/third_party/crashpad/crashpad/util/string/split_string_test.cc
index 7d205319c624324ae801c396bf37482e6f219f1e..2da5a2adaf9f3c51853b3cd506868b9d0bc93b58 100644
--- a/third_party/crashpad/crashpad/util/string/split_string_test.cc
+++ b/third_party/crashpad/crashpad/util/string/split_string_test.cc
@@ -20,42 +20,74 @@ namespace crashpad {
namespace test {
namespace {
-TEST(SplitString, SplitString) {
+TEST(SplitString, SplitStringFirst) {
std::string left;
std::string right;
- EXPECT_FALSE(SplitString("", '=', &left, &right));
- EXPECT_FALSE(SplitString("no equals", '=', &left, &right));
- EXPECT_FALSE(SplitString("=", '=', &left, &right));
- EXPECT_FALSE(SplitString("=beginequals", '=', &left, &right));
+ EXPECT_FALSE(SplitStringFirst("", '=', &left, &right));
+ EXPECT_FALSE(SplitStringFirst("no equals", '=', &left, &right));
+ EXPECT_FALSE(SplitStringFirst("=", '=', &left, &right));
+ EXPECT_FALSE(SplitStringFirst("=beginequals", '=', &left, &right));
- ASSERT_TRUE(SplitString("a=b", '=', &left, &right));
+ ASSERT_TRUE(SplitStringFirst("a=b", '=', &left, &right));
EXPECT_EQ("a", left);
EXPECT_EQ("b", right);
- ASSERT_TRUE(SplitString("EndsEquals=", '=', &left, &right));
+ ASSERT_TRUE(SplitStringFirst("EndsEquals=", '=', &left, &right));
EXPECT_EQ("EndsEquals", left);
EXPECT_TRUE(right.empty());
- ASSERT_TRUE(SplitString("key=VALUE", '=', &left, &right));
+ ASSERT_TRUE(SplitStringFirst("key=VALUE", '=', &left, &right));
EXPECT_EQ("key", left);
EXPECT_EQ("VALUE", right);
- EXPECT_FALSE(SplitString("a=b", '|', &left, &right));
+ EXPECT_FALSE(SplitStringFirst("a=b", '|', &left, &right));
- ASSERT_TRUE(SplitString("ls | less", '|', &left, &right));
+ ASSERT_TRUE(SplitStringFirst("ls | less", '|', &left, &right));
EXPECT_EQ("ls ", left);
EXPECT_EQ(" less", right);
- ASSERT_TRUE(SplitString("when in", ' ', &left, &right));
+ ASSERT_TRUE(SplitStringFirst("when in", ' ', &left, &right));
EXPECT_EQ("when", left);
EXPECT_EQ("in", right);
- ASSERT_TRUE(SplitString("zoo", 'o', &left, &right));
+ ASSERT_TRUE(SplitStringFirst("zoo", 'o', &left, &right));
EXPECT_EQ("z", left);
EXPECT_EQ("o", right);
- ASSERT_FALSE(SplitString("ooze", 'o', &left, &right));
+ ASSERT_FALSE(SplitStringFirst("ooze", 'o', &left, &right));
+}
+
+TEST(SplitString, SplitString) {
+ std::vector<std::string> parts;
+
+ parts = SplitString("", '.');
+ EXPECT_EQ(0u, parts.size());
+
+ parts = SplitString(".", '.');
+ ASSERT_EQ(2u, parts.size());
+ EXPECT_EQ("", parts[0]);
+ EXPECT_EQ("", parts[1]);
+
+ parts = SplitString("a,b", ',');
+ ASSERT_EQ(2u, parts.size());
+ EXPECT_EQ("a", parts[0]);
+ EXPECT_EQ("b", parts[1]);
+
+ parts = SplitString("zoo", 'o');
+ ASSERT_EQ(3u, parts.size());
+ EXPECT_EQ("z", parts[0]);
+ EXPECT_EQ("", parts[1]);
+ EXPECT_EQ("", parts[2]);
+
+ parts = SplitString("0x100,0x200,0x300,0x400,0x500,0x600", ',');
+ ASSERT_EQ(6u, parts.size());
+ EXPECT_EQ("0x100", parts[0]);
+ EXPECT_EQ("0x200", parts[1]);
+ EXPECT_EQ("0x300", parts[2]);
+ EXPECT_EQ("0x400", parts[3]);
+ EXPECT_EQ("0x500", parts[4]);
+ EXPECT_EQ("0x600", parts[5]);
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698