third_party/crashpad/crashpad/snapshot/win/exception_snapshot_win_test.cc - Issue 2478633002: Update Crashpad to b47bf6c250c6b825dee1c5fbad9152c2c962e828

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/snapshot/win/exception_snapshot_win_test.cc

Issue 2478633002: Update Crashpad to b47bf6c250c6b825dee1c5fbad9152c2c962e828 (Closed)

Patch Set: mac comment 2 Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/crashpad/crashpad/snapshot/win/end_to_end_test.py ('k') | third_party/crashpad/crashpad/test/multiprocess_exec_posix.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/crashpad/crashpad/snapshot/win/exception_snapshot_win_test.cc

diff --git a/third_party/crashpad/crashpad/snapshot/win/exception_snapshot_win_test.cc b/third_party/crashpad/crashpad/snapshot/win/exception_snapshot_win_test.cc

index 88612df31761082b22031ff3d4c1732f5135973b..af0cc3a61a8fbf110fdc865f9945d0423a08c605 100644

--- a/third_party/crashpad/crashpad/snapshot/win/exception_snapshot_win_test.cc

+++ b/third_party/crashpad/crashpad/snapshot/win/exception_snapshot_win_test.cc

@@ -126,7 +126,8 @@ void TestCrashingChild(const base::string16& directory_modification) {

CrashingDelegate delegate(server_ready.get(), completed.get());

ExceptionHandlerServer exception_handler_server(true);

- std::wstring pipe_name = exception_handler_server.CreatePipe();

+ std::wstring pipe_name(L"\\\\.\\pipe\\test_name");

+ exception_handler_server.SetPipeName(pipe_name);

RunServerThread server_thread(&exception_handler_server, &delegate);

server_thread.Start();

ScopedStopServerAndJoinThread scoped_stop_server_and_join_thread(

@@ -227,7 +228,8 @@ void TestDumpWithoutCrashingChild(

SimulateDelegate delegate(server_ready.get(), completed.get());