Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Unified Diff: third_party/crashpad/crashpad/tools/mac/run_with_crashpad.cc

Issue 2478633002: Update Crashpad to b47bf6c250c6b825dee1c5fbad9152c2c962e828 (Closed)
Patch Set: mac comment 2 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/tools/mac/run_with_crashpad.cc
diff --git a/third_party/crashpad/crashpad/tools/mac/run_with_crashpad.cc b/third_party/crashpad/crashpad/tools/mac/run_with_crashpad.cc
index 9b38ed80d06bc90ebfd858ab44fc519b0d7fb932..135d6d984a90a1fc1d10d20f500e1c78c6e72c86 100644
--- a/third_party/crashpad/crashpad/tools/mac/run_with_crashpad.cc
+++ b/third_party/crashpad/crashpad/tools/mac/run_with_crashpad.cc
@@ -115,7 +115,7 @@ int RunWithCrashpadMain(int argc, char* argv[]) {
case kOptionAnnotation: {
std::string key;
std::string value;
- if (!SplitString(optarg, '=', &key, &value)) {
+ if (!SplitStringFirst(optarg, '=', &key, &value)) {
ToolSupport::UsageHint(me, "--annotation requires KEY=VALUE");
return EXIT_FAILURE;
}
@@ -168,14 +168,11 @@ int RunWithCrashpadMain(int argc, char* argv[]) {
options.url,
options.annotations,
options.arguments,
+ false,
false)) {
return kExitFailure;
}
- if (!crashpad_client.UseHandler()) {
- return kExitFailure;
- }
-
// Using the remaining arguments, start a new program with the new exception
// port in effect.
execvp(argv[0], argv);
« no previous file with comments | « third_party/crashpad/crashpad/test/win/win_child_process.cc ('k') | third_party/crashpad/crashpad/util/file/file_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698