Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2477973002: Exclude third_party/crashpad from IPC presubmit (Closed)

Created:
2 years, 9 months ago by scottmg
Modified:
2 years, 9 months ago
Reviewers:
Dirk Pranke, dcheng
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Exclude third_party/crashpad from IPC presubmit Can't otherwise land https://codereview.chromium.org/2478633002/. R=dcheng@chromium.org, dpranke@chromium.org BUG=661788 Committed: https://crrev.com/7a6ed5baee360f6521c8311a4dc5b1edba849679 Cr-Commit-Position: refs/heads/master@{#429954}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M PRESUBMIT.py View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (15 generated)
scottmg
2 years, 9 months ago (2016-11-03 23:50:44 UTC) #3
dcheng
lgtm
2 years, 9 months ago (2016-11-04 01:45:37 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2477973002/1
2 years, 9 months ago (2016-11-04 02:12:01 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/296724)
2 years, 9 months ago (2016-11-04 02:20:32 UTC) #16
Dirk Pranke
lgtm
2 years, 9 months ago (2016-11-04 17:15:05 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2477973002/1
2 years, 9 months ago (2016-11-04 18:16:36 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
2 years, 9 months ago (2016-11-04 18:22:34 UTC) #21
commit-bot: I haz the power
2 years, 9 months ago (2016-11-04 18:48:08 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a6ed5baee360f6521c8311a4dc5b1edba849679
Cr-Commit-Position: refs/heads/master@{#429954}

Powered by Google App Engine
This is Rietveld 408576698