Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: third_party/crashpad/crashpad/util/win/exception_handler_server_test.cc

Issue 2478633002: Update Crashpad to b47bf6c250c6b825dee1c5fbad9152c2c962e828 (Closed)
Patch Set: mac comment 2 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/util/win/exception_handler_server_test.cc
diff --git a/third_party/crashpad/crashpad/util/win/exception_handler_server_test.cc b/third_party/crashpad/crashpad/util/win/exception_handler_server_test.cc
index 54a048705cd9799405af35124fc463fa7a173892..e94b91d5da6df88fa5f0cb7d232d5966bc353f99 100644
--- a/third_party/crashpad/crashpad/util/win/exception_handler_server_test.cc
+++ b/third_party/crashpad/crashpad/util/win/exception_handler_server_test.cc
@@ -81,10 +81,12 @@ class ExceptionHandlerServerTest : public testing::Test {
public:
ExceptionHandlerServerTest()
: server_(true),
- pipe_name_(server_.CreatePipe()),
+ pipe_name_(L"\\\\.\\pipe\\test_name"),
server_ready_(CreateEvent(nullptr, false, false, nullptr)),
delegate_(server_ready_.get()),
- server_thread_(&server_, &delegate_) {}
+ server_thread_(&server_, &delegate_) {
+ server_.SetPipeName(pipe_name_);
+ }
TestDelegate& delegate() { return delegate_; }
ExceptionHandlerServer& server() { return server_; }
@@ -171,10 +173,6 @@ class TestClient final : public WinChildProcess {
ADD_FAILURE();
return EXIT_FAILURE;
}
- if (!client.UseHandler()) {
- ADD_FAILURE();
- return EXIT_FAILURE;
- }
WriteWString(WritePipeHandle(), L"OK");
return EXIT_SUCCESS;
}

Powered by Google App Engine
This is Rietveld 408576698