Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Unified Diff: third_party/crashpad/crashpad/handler/crash_report_upload_thread.cc

Issue 2478633002: Update Crashpad to b47bf6c250c6b825dee1c5fbad9152c2c962e828 (Closed)
Patch Set: mac comment 2 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/handler/crash_report_upload_thread.cc
diff --git a/third_party/crashpad/crashpad/handler/crash_report_upload_thread.cc b/third_party/crashpad/crashpad/handler/crash_report_upload_thread.cc
index 23dda482fa1515c8e527986cf011b05a3503ee59..5bd1fbf9318d7084f97bc2b57b3e3e184dcb2313 100644
--- a/third_party/crashpad/crashpad/handler/crash_report_upload_thread.cc
+++ b/third_party/crashpad/crashpad/handler/crash_report_upload_thread.cc
@@ -207,9 +207,12 @@ void CrashReportUploadThread::ProcessPendingReport(
// hour, and retire reports that would exceed this limit or for which the
// upload fails on the first attempt.
//
+ // If upload was requested explicitly (i.e. by user action), we do not
+ // throttle the upload.
+ //
// TODO(mark): Provide a proper rate-limiting strategy and allow for failed
// upload attempts to be retried.
- if (rate_limit_) {
+ if (!report.upload_explicitly_requested && rate_limit_) {
time_t last_upload_attempt_time;
if (settings->GetLastUploadAttemptTime(&last_upload_attempt_time)) {
time_t now = time(nullptr);
« no previous file with comments | « third_party/crashpad/crashpad/doc/status.ad ('k') | third_party/crashpad/crashpad/handler/crashpad_handler.ad » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698