third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_dump_without_crashing.cc - Issue 2478633002: Update Crashpad to b47bf6c250c6b825dee1c5fbad9152c2c962e828

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_dump_without_crashing.cc

Issue 2478633002: Update Crashpad to b47bf6c250c6b825dee1c5fbad9152c2c962e828 (Closed)

Patch Set: mac comment 2 Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_crashing_child.cc ('k') | third_party/crashpad/crashpad/snapshot/win/end_to_end_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_dump_without_crashing.cc

diff --git a/third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_dump_without_crashing.cc b/third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_dump_without_crashing.cc

index cf5ab9505cb8e37248aa01d68e08c34eee309e4d..b6c9814aea4c5240a4c433ad8792f3f1e7bf0377 100644

--- a/third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_dump_without_crashing.cc

+++ b/third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_dump_without_crashing.cc

@@ -33,7 +33,6 @@ int wmain(int argc, wchar_t* argv[]) {

crashpad::CrashpadClient client;

CHECK(client.SetHandlerIPCPipe(argv[1]));

- CHECK(client.UseHandler());

HANDLE out = GetStdHandle(STD_OUTPUT_HANDLE);

PCHECK(out != INVALID_HANDLE_VALUE) << "GetStdHandle";