Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Issue 2478253002: Revert of Remove CPDF_Object::Release() in favor of direct delete (Closed)

Created:
4 years, 1 month ago by dsinclair
Modified:
4 years, 1 month ago
Reviewers:
Lei Zhang, Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Revert of Remove CPDF_Object::Release() in favor of direct delete (patchset #11 id:200001 of https://codereview.chromium.org/2384883003/ ) Reason for revert: Looks like it's blocking the roll. https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/186619 Original issue's description: > Remove CPDF_Object::Release() in favor of direct delete > > Follow-on once we prove Release always deletes in previous CL. > > Committed: https://pdfium.googlesource.com/pdfium/+/4de3d095c9d9e961f93750cf1ebd489fd515be12 TBR=thestig@chromium.org,tsepez@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://pdfium.googlesource.com/pdfium/+/f0d5b6c35fa343108a3ab7a25bc2cc2b3cf105b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+286 lines, -211 lines) Patch
M core/fpdfapi/edit/cpdf_creator.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/edit/fpdf_edit_create.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M core/fpdfapi/font/fpdf_font.cpp View 1 chunk +5 lines, -2 lines 0 comments Download
M core/fpdfapi/page/cpdf_contentmark.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M core/fpdfapi/page/cpdf_contentmarkitem.h View 1 chunk +4 lines, -2 lines 0 comments Download
M core/fpdfapi/page/cpdf_contentmarkitem.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/page/cpdf_image.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfapi/page/cpdf_image.cpp View 3 chunks +8 lines, -10 lines 0 comments Download
M core/fpdfapi/page/cpdf_streamcontentparser.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/page/cpdf_streamcontentparser.cpp View 9 chunks +24 lines, -19 lines 0 comments Download
M core/fpdfapi/page/fpdf_page_parser_old.cpp View 4 chunks +10 lines, -6 lines 0 comments Download
M core/fpdfapi/parser/cfdf_document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/parser/cpdf_array.h View 3 chunks +5 lines, -3 lines 0 comments Download
M core/fpdfapi/parser/cpdf_array.cpp View 3 chunks +8 lines, -5 lines 0 comments Download
M core/fpdfapi/parser/cpdf_array_unittest.cpp View 8 chunks +16 lines, -10 lines 0 comments Download
M core/fpdfapi/parser/cpdf_data_avail.cpp View 15 chunks +44 lines, -37 lines 0 comments Download
M core/fpdfapi/parser/cpdf_dictionary.h View 4 chunks +7 lines, -4 lines 0 comments Download
M core/fpdfapi/parser/cpdf_dictionary.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M core/fpdfapi/parser/cpdf_document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/parser/cpdf_document_unittest.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M core/fpdfapi/parser/cpdf_indirect_object_holder.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/parser/cpdf_indirect_object_holder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/parser/cpdf_object.h View 4 chunks +6 lines, -2 lines 0 comments Download
M core/fpdfapi/parser/cpdf_object.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M core/fpdfapi/parser/cpdf_object_unittest.cpp View 27 chunks +40 lines, -36 lines 0 comments Download
M core/fpdfapi/parser/cpdf_parser.cpp View 14 chunks +36 lines, -22 lines 0 comments Download
M core/fpdfapi/parser/cpdf_stream.h View 3 chunks +6 lines, -4 lines 0 comments Download
M core/fpdfapi/parser/cpdf_stream.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/parser/cpdf_string.h View 2 chunks +2 lines, -1 line 0 comments Download
M core/fpdfapi/parser/cpdf_syntax_parser.cpp View 7 chunks +10 lines, -7 lines 0 comments Download
M core/fpdfdoc/cpdf_annot.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/cpdf_filespec_unittest.cpp View 6 chunks +12 lines, -5 lines 0 comments Download
M core/fpdfdoc/cpdf_formfield.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M core/fxge/dib/fx_dib_engine_unittest.cpp View 1 chunk +4 lines, -5 lines 0 comments Download
M fpdfsdk/fpdfdoc_unittest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfppo.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
dsinclair
Created Revert of Remove CPDF_Object::Release() in favor of direct delete
4 years, 1 month ago (2016-11-04 15:25:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478253002/1
4 years, 1 month ago (2016-11-04 15:25:18 UTC) #3
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 15:25:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/f0d5b6c35fa343108a3ab7a25bc2cc2b3cf1...

Powered by Google App Engine
This is Rietveld 408576698