fpdfsdk/fpdfdoc_unittest.cpp - Issue 2478253002: Revert of Remove CPDF_Object::Release() in favor of direct delete

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/fpdfdoc_unittest.cpp

Issue 2478253002: Revert of Remove CPDF_Object::Release() in favor of direct delete (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/fpdfdoc_unittest.cpp

diff --git a/fpdfsdk/fpdfdoc_unittest.cpp b/fpdfsdk/fpdfdoc_unittest.cpp

index 39e81d52e8d03ff977f03b2d06c7c867398ada12..408d2fa0d820a56ec33034562e992126635589bf 100644

--- a/fpdfsdk/fpdfdoc_unittest.cpp

+++ b/fpdfsdk/fpdfdoc_unittest.cpp

@@ -87,7 +87,7 @@

protected:

std::unique_ptr<CPDF_TestPdfDocument> m_pDoc;

CPDF_IndirectObjectHolder* m_pIndirectObjs;

- std::unique_ptr<CPDF_Dictionary> m_pRootObj;

+ std::unique_ptr<CPDF_Dictionary, ReleaseDeleter<CPDF_Dictionary>> m_pRootObj;

};

TEST_F(PDFDocTest, FindBookmark) {

« no previous file with comments | « core/fxge/dib/fx_dib_engine_unittest.cpp ('k') | fpdfsdk/fpdfppo.cpp » ('j') | no next file with comments »