core/fpdfdoc/cpdf_formfield.cpp - Issue 2478253002: Revert of Remove CPDF_Object::Release() in favor of direct delete

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfdoc/cpdf_formfield.cpp

Issue 2478253002: Revert of Remove CPDF_Object::Release() in favor of direct delete (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfdoc/cpdf_formfield.cpp

diff --git a/core/fpdfdoc/cpdf_formfield.cpp b/core/fpdfdoc/cpdf_formfield.cpp

index e2240c9f2f09fa1583a41193ef8303e6a1c3724d..e82ef7800e2404a852e7c9e6882a18a6b5b70e53 100644

--- a/core/fpdfdoc/cpdf_formfield.cpp

+++ b/core/fpdfdoc/cpdf_formfield.cpp

@@ -575,7 +575,8 @@

if (pValue->GetUnicodeText() == opt_value)

m_pDict->RemoveFor("V");

} else if (pValue->IsArray()) {

- std::unique_ptr<CPDF_Array> pArray(new CPDF_Array);

+ std::unique_ptr<CPDF_Array, ReleaseDeleter<CPDF_Array>> pArray(

+ new CPDF_Array);

for (int i = 0; i < CountOptions(); i++) {

if (i != index && IsItemSelected(i)) {

opt_value = GetOptionValue(i);

« no previous file with comments | « core/fpdfdoc/cpdf_filespec_unittest.cpp ('k') | core/fxge/dib/fx_dib_engine_unittest.cpp » ('j') | no next file with comments »