Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Side by Side Diff: core/fpdfapi/parser/cpdf_object.cpp

Issue 2478253002: Revert of Remove CPDF_Object::Release() in favor of direct delete (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « core/fpdfapi/parser/cpdf_object.h ('k') | core/fpdfapi/parser/cpdf_object_unittest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 PDFium Authors. All rights reserved. 1 // Copyright 2016 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "core/fpdfapi/parser/cpdf_object.h" 7 #include "core/fpdfapi/parser/cpdf_object.h"
8 8
9 #include <algorithm> 9 #include <algorithm>
10 10
(...skipping 19 matching lines...) Expand all
30 CPDF_Object* CPDF_Object::CloneDirectObject() const { 30 CPDF_Object* CPDF_Object::CloneDirectObject() const {
31 return CloneObjectNonCyclic(true); 31 return CloneObjectNonCyclic(true);
32 } 32 }
33 33
34 CPDF_Object* CPDF_Object::CloneNonCyclic( 34 CPDF_Object* CPDF_Object::CloneNonCyclic(
35 bool bDirect, 35 bool bDirect,
36 std::set<const CPDF_Object*>* pVisited) const { 36 std::set<const CPDF_Object*>* pVisited) const {
37 return Clone(); 37 return Clone();
38 } 38 }
39 39
40 void CPDF_Object::Release() {
41 CHECK(!m_ObjNum);
42 delete this;
43 }
44
40 CFX_ByteString CPDF_Object::GetString() const { 45 CFX_ByteString CPDF_Object::GetString() const {
41 return CFX_ByteString(); 46 return CFX_ByteString();
42 } 47 }
43 48
44 CFX_WideString CPDF_Object::GetUnicodeText() const { 49 CFX_WideString CPDF_Object::GetUnicodeText() const {
45 return CFX_WideString(); 50 return CFX_WideString();
46 } 51 }
47 52
48 FX_FLOAT CPDF_Object::GetNumber() const { 53 FX_FLOAT CPDF_Object::GetNumber() const {
49 return 0; 54 return 0;
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 return nullptr; 154 return nullptr;
150 } 155 }
151 156
152 CPDF_String* CPDF_Object::AsString() { 157 CPDF_String* CPDF_Object::AsString() {
153 return nullptr; 158 return nullptr;
154 } 159 }
155 160
156 const CPDF_String* CPDF_Object::AsString() const { 161 const CPDF_String* CPDF_Object::AsString() const {
157 return nullptr; 162 return nullptr;
158 } 163 }
OLDNEW
« no previous file with comments | « core/fpdfapi/parser/cpdf_object.h ('k') | core/fpdfapi/parser/cpdf_object_unittest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698