Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Unified Diff: core/fxge/dib/fx_dib_engine_unittest.cpp

Issue 2478253002: Revert of Remove CPDF_Object::Release() in favor of direct delete (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « core/fpdfdoc/cpdf_formfield.cpp ('k') | fpdfsdk/fpdfdoc_unittest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/fxge/dib/fx_dib_engine_unittest.cpp
diff --git a/core/fxge/dib/fx_dib_engine_unittest.cpp b/core/fxge/dib/fx_dib_engine_unittest.cpp
index 57e829e9d2babe19182481ee5d3c4c63c522aa23..3f8abe1c971bc92a2a2dd5853c10ff9610590e5f 100644
--- a/core/fxge/dib/fx_dib_engine_unittest.cpp
+++ b/core/fxge/dib/fx_dib_engine_unittest.cpp
@@ -12,16 +12,15 @@
#include "core/fxge/dib/dib_int.h"
#include "core/fxge/fx_dib.h"
#include "testing/gtest/include/gtest/gtest.h"
-#include "third_party/base/ptr_util.h"
TEST(CStretchEngine, OverflowInCtor) {
FX_RECT clip_rect;
- std::unique_ptr<CPDF_Dictionary> dict_obj =
- pdfium::MakeUnique<CPDF_Dictionary>();
+ std::unique_ptr<CPDF_Dictionary, ReleaseDeleter<CPDF_Dictionary>> dict_obj(
+ new CPDF_Dictionary());
dict_obj->SetFor("Width", new CPDF_Number(71000));
dict_obj->SetFor("Height", new CPDF_Number(12500));
- std::unique_ptr<CPDF_Stream> stream =
- pdfium::MakeUnique<CPDF_Stream>(nullptr, 0, dict_obj.release());
+ std::unique_ptr<CPDF_Stream, ReleaseDeleter<CPDF_Stream>> stream(
+ new CPDF_Stream(nullptr, 0, dict_obj.release()));
CPDF_DIBSource dib_source;
dib_source.Load(nullptr, stream.get(), nullptr, nullptr, nullptr, nullptr,
false, 0, false);
« no previous file with comments | « core/fpdfdoc/cpdf_formfield.cpp ('k') | fpdfsdk/fpdfdoc_unittest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698